Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Ola Liljedahl
On 05/09/2016, 09:40, "Alexander Graf" wrote: >On 09/04/2016 05:47 PM, Ola Liljedahl wrote: >> >> On 02/09/2016, 16:05, "Alexander Graf" wrote: >> > There is a big problem that the control handle logic is >synchronization, > but the data queue > handling logic is asynchronizati

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Gonglei (Arei)
> > > On 09/03/2016 05:18 AM, Gonglei (Arei) wrote: > > Hi, > > > >> -Original Message- > >> From: Alexander Graf [mailto:ag...@suse.de] > >> Sent: Friday, September 02, 2016 10:05 PM > >> Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > >> > >> > >> >

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Alexander Graf
On 09/04/2016 05:47 PM, Ola Liljedahl wrote: > > On 02/09/2016, 16:05, "Alexander Graf" wrote: > There is a big problem that the control handle logic is synchronization, but the data queue handling logic is asynchronization. We can't combine them into one queue. It will de

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-05 Thread Alexander Graf
On 09/03/2016 05:18 AM, Gonglei (Arei) wrote: Hi, -Original Message- From: Alexander Graf [mailto:ag...@suse.de] Sent: Friday, September 02, 2016 10:05 PM Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification On 02.09.16 14:16, Ola Liljedahl wrote: On 0

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-04 Thread Ola Liljedahl
On 02/09/2016, 16:05, "Alexander Graf" wrote: >>>There is a big problem that the control handle logic is synchronization, >>>but the data queue >>>handling logic is asynchronization. We can't combine them into one >>>queue. >>>It will decrease the performance because you need indentify each pac

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Gonglei (Arei)
Hi Stefan, > -Original Message- > From: Stefan Hajnoczi [mailto:stefa...@redhat.com] > Sent: Friday, September 02, 2016 8:07 PM > Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > > On Tue, Aug 30, 2016 at 08:12:15PM +0800, Gonglei wrote: > > Hi, > I

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, September 02, 2016 10:05 PM > Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > > > > On 02.09.16 14:16, Ola Liljedahl wrote: > > > > > > On 02/09/2016, 12:26, "Go

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Ma, Liang J [mailto:liang.j...@intel.com] > Sent: Friday, September 02, 2016 9:47 PM > Subject: RE: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > > Hi Lei, > For wireless algorithm > +#define VIRTIO_CRYPTO_MAC_CMAC_KA

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Gonglei (Arei)
Hi Alex, > -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, September 02, 2016 9:53 PM > Euler) > Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > > > > On 02.09.16 12:26, Gonglei (Arei) wrote: > > > >> -Original

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Ma, Liang J
Hi Lei, For wireless algorithm +#define VIRTIO_CRYPTO_MAC_CMAC_KASUMI_F9 27 +#define VIRTIO_CRYPTO_MAC_CMAC_SNOW3G_UIA228 I suggest rename as +#define VIRTIO_CRYPTO_MAC_KASUMI_F9 27 +#define VIRTIO_CRYPTO_MAC_SNOW3G_UIA228

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Alexander Graf
On 02.09.16 14:16, Ola Liljedahl wrote: > > > On 02/09/2016, 12:26, "Gonglei (Arei)" wrote: > >> >>> -Original Message- >>> From: Alexander Graf [mailto:ag...@suse.de] >>> Sent: Friday, September 02, 2016 4:07 PM >>> Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Alexander Graf
On 02.09.16 12:26, Gonglei (Arei) wrote: > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Friday, September 02, 2016 4:07 PM >> Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device >> specification >> >> >> >> On 02.09.16 05:08, Gonglei (Are

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Stefan Hajnoczi
On Tue, Aug 30, 2016 at 08:12:15PM +0800, Gonglei wrote: Hi, I have read through part of the spec and suggest mostly grammar fixes below. > The virtio crypto device is a virtual crypto device (ie. hardware > crypto accelerator card). The virtio crypto device can provide > five crypto services: CI

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Ola Liljedahl
On 02/09/2016, 12:26, "Gonglei (Arei)" wrote: > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Friday, September 02, 2016 4:07 PM >> Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device >>specification >> >> >> >> On 02.09.16 05:08, Gonglei

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Gonglei (Arei)
> -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Friday, September 02, 2016 4:07 PM > Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > > > > On 02.09.16 05:08, Gonglei (Arei) wrote: > > Hi Alex, > > > > > >> -Original M

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-02 Thread Alexander Graf
On 02.09.16 05:08, Gonglei (Arei) wrote: > Hi Alex, > > >> -Original Message- >> From: Alexander Graf [mailto:ag...@suse.de] >> Sent: Thursday, September 01, 2016 9:37 PM >> Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device >> specification >> >> On 08/30/2016 02:12 P

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-01 Thread Gonglei (Arei)
Hi Alex, > -Original Message- > From: Alexander Graf [mailto:ag...@suse.de] > Sent: Thursday, September 01, 2016 9:37 PM > Subject: Re: [PATCH v8 1/2] virtio-crypto: Add virtio crypto device > specification > > On 08/30/2016 02:12 PM, Gonglei wrote: > > The virtio crypto device is a vir

Re: [Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-09-01 Thread Alexander Graf
On 08/30/2016 02:12 PM, Gonglei wrote: The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introdu

[Qemu-devel] [PATCH v8 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-30 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei CC: Michael