Re: [Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for monolithicFlat image

2011-07-08 Thread Stefan Hajnoczi
On Tue, Jul 5, 2011 at 12:31 PM, Fam Zheng wrote: > +        ret = sscanf(p, "%10s %lld %10s %512s", [...] > +            ret = sscanf(p, "%10s %lld %10s %511s %lld", %512s -> %511s But instead of duplicating the format string and sscanf(3), I suggest doing sscanf(p, "%10s %lld %10s %511s %lld",

[Qemu-devel] [PATCH v8 09/12] VMDK: open/read/write for monolithicFlat image

2011-07-05 Thread Fam Zheng
Parse vmdk decriptor file and open mono flat image. Read/write the flat extent. Signed-off-by: Fam Zheng --- block/vmdk.c | 172 +- 1 files changed, 159 insertions(+), 13 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index f637d98