Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-18 Thread Fam Zheng
On Mon, 09/18 08:44, Kevin Wolf wrote: > > > > > +self._qemu_full_args = (self._wrapper + [self._binary] + > > > > > +self._base_args() + self._args) > > > > > > > > The parentheses seem superfluous. With those removed: > > > > > > > > Reviewed-by:

Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-17 Thread Kevin Wolf
Am 18.09.2017 um 07:39 hat Fam Zheng geschrieben: > On Mon, 09/18 07:18, Kevin Wolf wrote: > > Am 05.09.2017 um 05:02 hat Fam Zheng geschrieben: > > > On Fri, 09/01 13:28, Amador Pahim wrote: > > > > The current message shows 'self._args', which contains only part of the > > > > options used in the

Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-17 Thread Fam Zheng
On Mon, 09/18 07:18, Kevin Wolf wrote: > Am 05.09.2017 um 05:02 hat Fam Zheng geschrieben: > > On Fri, 09/01 13:28, Amador Pahim wrote: > > > The current message shows 'self._args', which contains only part of the > > > options used in the Qemu command line. > > > > > > This patch makes the qemu f

Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-17 Thread Kevin Wolf
Am 05.09.2017 um 05:02 hat Fam Zheng geschrieben: > On Fri, 09/01 13:28, Amador Pahim wrote: > > The current message shows 'self._args', which contains only part of the > > options used in the Qemu command line. > > > > This patch makes the qemu full args list an instance variable and then > > use

Re: [Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-04 Thread Fam Zheng
On Fri, 09/01 13:28, Amador Pahim wrote: > The current message shows 'self._args', which contains only part of the > options used in the Qemu command line. > > This patch makes the qemu full args list an instance variable and then > uses it in the negative exit code message. > > Message was moved

[Qemu-devel] [PATCH v8 04/13] qemu.py: improve message on negative exit code

2017-09-01 Thread Amador Pahim
The current message shows 'self._args', which contains only part of the options used in the Qemu command line. This patch makes the qemu full args list an instance variable and then uses it in the negative exit code message. Message was moved outside the 'if is_running' block to make sure it will