Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Fam Zheng
On Wed, 10/26 17:33, Kevin Wolf wrote: > > As we concluded above, this is really a matrix a two bools rather than a > single property. We need a new option for "I can't allow other processes > to write to the image", but we don't need one for "I am writing to the > image" because that's the read-o

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Max Reitz
On 26.10.2016 17:33, Kevin Wolf wrote: > Am 26.10.2016 um 17:12 hat Max Reitz geschrieben: >> On 26.10.2016 13:01, Fam Zheng wrote: >>> On Tue, 10/25 16:57, Kevin Wolf wrote: Am 25.10.2016 um 15:30 hat Max Reitz geschrieben: > On 25.10.2016 10:24, Kevin Wolf wrote: >> Am 24.10.2016 um

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Kevin Wolf
Am 26.10.2016 um 17:12 hat Max Reitz geschrieben: > On 26.10.2016 13:01, Fam Zheng wrote: > > On Tue, 10/25 16:57, Kevin Wolf wrote: > >> Am 25.10.2016 um 15:30 hat Max Reitz geschrieben: > >>> On 25.10.2016 10:24, Kevin Wolf wrote: > Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: > > O

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Max Reitz
On 26.10.2016 13:01, Fam Zheng wrote: > On Tue, 10/25 16:57, Kevin Wolf wrote: >> Am 25.10.2016 um 15:30 hat Max Reitz geschrieben: >>> On 25.10.2016 10:24, Kevin Wolf wrote: Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: > On 24.10.2016 12:11, Kevin Wolf wrote: > > [...] >

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Max Reitz
On 25.10.2016 16:57, Kevin Wolf wrote: > Am 25.10.2016 um 15:30 hat Max Reitz geschrieben: >> On 25.10.2016 10:24, Kevin Wolf wrote: >>> Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: On 24.10.2016 12:11, Kevin Wolf wrote: [...] > Now, the big question is how to translate

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-26 Thread Fam Zheng
On Tue, 10/25 16:57, Kevin Wolf wrote: > Am 25.10.2016 um 15:30 hat Max Reitz geschrieben: > > On 25.10.2016 10:24, Kevin Wolf wrote: > > > Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: > > >> On 24.10.2016 12:11, Kevin Wolf wrote: > > >> > > >> [...] > > >> > > >>> Now, the big question is how

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Kevin Wolf
Am 25.10.2016 um 15:30 hat Max Reitz geschrieben: > On 25.10.2016 10:24, Kevin Wolf wrote: > > Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: > >> On 24.10.2016 12:11, Kevin Wolf wrote: > >> > >> [...] > >> > >>> Now, the big question is how to translate this into file locking. This > >>> could

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Max Reitz
On 25.10.2016 10:24, Kevin Wolf wrote: > Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: >> On 24.10.2016 12:11, Kevin Wolf wrote: >> >> [...] >> >>> Now, the big question is how to translate this into file locking. This >>> could become a little tricky. I had a few thoughts involving another >>>

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Fam Zheng
On Tue, 10/25 09:06, Richard W.M. Jones wrote: > On Tue, Oct 25, 2016 at 03:09:51PM +0800, Fam Zheng wrote: > > On Mon, 10/24 12:11, Kevin Wolf wrote: > > > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > > > > > > > > > > I personally still don't like making locking a qdev property very

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Kevin Wolf
Am 24.10.2016 um 20:03 hat Max Reitz geschrieben: > On 24.10.2016 12:11, Kevin Wolf wrote: > > [...] > > > Now, the big question is how to translate this into file locking. This > > could become a little tricky. I had a few thoughts involving another > > lock on byte 2, but none of them actually

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Richard W.M. Jones
On Tue, Oct 25, 2016 at 03:09:51PM +0800, Fam Zheng wrote: > On Mon, 10/24 12:11, Kevin Wolf wrote: > > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > > > > > > > I personally still don't like making locking a qdev property very much > > > because it doesn't make sense to me*. But I reme

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-25 Thread Fam Zheng
On Mon, 10/24 12:11, Kevin Wolf wrote: > Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > > > > I personally still don't like making locking a qdev property very much > > because it doesn't make sense to me*. But I remember Kevin had his > > reasons (even though I can no longer remember th

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-24 Thread Max Reitz
On 24.10.2016 12:11, Kevin Wolf wrote: [...] > Now, the big question is how to translate this into file locking. This > could become a little tricky. I had a few thoughts involving another > lock on byte 2, but none of them actually worked out so far, because > what we want is essentially a lock

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-24 Thread Kevin Wolf
Am 22.10.2016 um 03:00 hat Max Reitz geschrieben: > > > I personally still don't like making locking a qdev property very much > because it doesn't make sense to me*. But I remember Kevin had his > reasons (even though I can no longer remember them) for asking for it, > and I don't have any besid

Re: [Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-10-21 Thread Max Reitz
On 30.09.2016 14:09, Fam Zheng wrote: > Hi all, > > I wanted to post something before the long holiday as promised, but I couldn't > refine or test enough due to limited time. Please take this as an RFC and do > a > high level review. Thanks. I did that, looked at some patches in more and at so

[Qemu-devel] [PATCH v8 00/36] block: Image locking series

2016-09-30 Thread Fam Zheng
Hi all, I wanted to post something before the long holiday as promised, but I couldn't refine or test enough due to limited time. Please take this as an RFC and do a high level review. Thanks. v8: Move user interface option from block device to qdev. [Kevin] Add "exclusive" back. [Kevin]