Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-19 Thread Stefan Hajnoczi
On Wed, Jun 18, 2014 at 02:35:21PM +0200, Greg Kurz wrote: > On Wed, 18 Jun 2014 18:38:14 +0800 > Stefan Hajnoczi wrote: > > > On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote: > > > > > > On 17.06.14 09:36, Stefan Hajnoczi wrote: > > > >On Fri, Jun 13, 2014 at 01:18:00PM +0200, Gr

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Alexander Graf
On 18.06.14 17:40, Peter Maydell wrote: On 18 June 2014 16:37, Alexander Graf wrote: I actually agree with Greg here. We implicitly create different VGA adapters today depending on TARGET_WORDS_BIGENDIAN. The FB endianness should have been separate devices (BE / LE) or runtime configuration fr

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Peter Maydell
On 18 June 2014 16:37, Alexander Graf wrote: > I actually agree with Greg here. We implicitly create different VGA adapters > today depending on TARGET_WORDS_BIGENDIAN. The FB endianness should have > been separate devices (BE / LE) or runtime configuration from the beginning. > > Anything that ch

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Alexander Graf
On 18.06.14 17:35, Peter Maydell wrote: On 18 June 2014 15:28, Greg Kurz wrote: On Wed, 18 Jun 2014 16:42:04 +0300 "Michael S. Tsirkin" wrote: On Wed, Jun 18, 2014 at 01:53:15PM +0100, Peter Maydell wrote: On 18 June 2014 11:38, Stefan Hajnoczi wrote: What bothers me is that real hardware

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Peter Maydell
On 18 June 2014 15:28, Greg Kurz wrote: > On Wed, 18 Jun 2014 16:42:04 +0300 > "Michael S. Tsirkin" wrote: >> On Wed, Jun 18, 2014 at 01:53:15PM +0100, Peter Maydell wrote: >> > On 18 June 2014 11:38, Stefan Hajnoczi wrote: >> > > What bothers me is that real hardware can't do this. >> > >> > Re

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Michael S. Tsirkin
On Wed, Jun 18, 2014 at 05:14:17PM +0200, Alexander Graf wrote: > > On 18.06.14 17:12, Michael S. Tsirkin wrote: > >On Wed, Jun 18, 2014 at 02:35:21PM +0200, Greg Kurz wrote: > >>On Wed, 18 Jun 2014 18:38:14 +0800 > >>Stefan Hajnoczi wrote: > >> > >>>On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alex

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Alexander Graf
On 18.06.14 17:12, Michael S. Tsirkin wrote: On Wed, Jun 18, 2014 at 02:35:21PM +0200, Greg Kurz wrote: On Wed, 18 Jun 2014 18:38:14 +0800 Stefan Hajnoczi wrote: On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote: On 17.06.14 09:36, Stefan Hajnoczi wrote: On Fri, Jun 13, 2014 a

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Michael S. Tsirkin
On Wed, Jun 18, 2014 at 02:35:21PM +0200, Greg Kurz wrote: > On Wed, 18 Jun 2014 18:38:14 +0800 > Stefan Hajnoczi wrote: > > > On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote: > > > > > > On 17.06.14 09:36, Stefan Hajnoczi wrote: > > > >On Fri, Jun 13, 2014 at 01:18:00PM +0200, Gr

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Michael S. Tsirkin
On Wed, Jun 18, 2014 at 04:28:04PM +0200, Greg Kurz wrote: > On Wed, 18 Jun 2014 16:42:04 +0300 > "Michael S. Tsirkin" wrote: > > On Wed, Jun 18, 2014 at 01:53:15PM +0100, Peter Maydell wrote: > > > On 18 June 2014 11:38, Stefan Hajnoczi wrote: > > > > What bothers me is that real hardware can't

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Greg Kurz
On Wed, 18 Jun 2014 16:42:04 +0300 "Michael S. Tsirkin" wrote: > On Wed, Jun 18, 2014 at 01:53:15PM +0100, Peter Maydell wrote: > > On 18 June 2014 11:38, Stefan Hajnoczi wrote: > > > What bothers me is that real hardware can't do this. > > > > Real hardware doesn't have "endianness matches gues

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Michael S. Tsirkin
On Wed, Jun 18, 2014 at 01:53:15PM +0100, Peter Maydell wrote: > On 18 June 2014 11:38, Stefan Hajnoczi wrote: > > What bothers me is that real hardware can't do this. > > Real hardware doesn't have "endianness matches guest CPU endianness" > semantics, which is what the virtio spec mandates...

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Peter Maydell
On 18 June 2014 11:38, Stefan Hajnoczi wrote: > What bothers me is that real hardware can't do this. Real hardware doesn't have "endianness matches guest CPU endianness" semantics, which is what the virtio spec mandates... > Given that VIRTIO > 1.0 is always little-endian I guess this is just a

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Greg Kurz
On Wed, 18 Jun 2014 18:38:14 +0800 Stefan Hajnoczi wrote: > On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote: > > > > On 17.06.14 09:36, Stefan Hajnoczi wrote: > > >On Fri, Jun 13, 2014 at 01:18:00PM +0200, Greg Kurz wrote: > > >>This version merges the changes requested during the

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-18 Thread Stefan Hajnoczi
On Tue, Jun 17, 2014 at 09:40:19AM +0200, Alexander Graf wrote: > > On 17.06.14 09:36, Stefan Hajnoczi wrote: > >On Fri, Jun 13, 2014 at 01:18:00PM +0200, Greg Kurz wrote: > >>This version merges the changes requested during the v7 review, remarks from > >>ppc64 dump support review (yes, we talked

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-17 Thread Alexander Graf
On 17.06.14 09:36, Stefan Hajnoczi wrote: On Fri, Jun 13, 2014 at 01:18:00PM +0200, Greg Kurz wrote: This version merges the changes requested during the v7 review, remarks from ppc64 dump support review (yes, we talked about virtio there) and the work on virtio subsections migration. Also two

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-17 Thread Stefan Hajnoczi
On Fri, Jun 13, 2014 at 01:18:00PM +0200, Greg Kurz wrote: > This version merges the changes requested during the v7 review, remarks from > ppc64 dump support review (yes, we talked about virtio there) and the work on > virtio subsections migration. Also two new patches have been added: > - patch #

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-16 Thread Amit Shah
On (Mon) 16 Jun 2014 [17:07:01], Greg Kurz wrote: > Hi, > > I've reworked the patch set according to Alex's last remarks. Do any of the > other maintainers have pending remarks ? Should I wait or send a v9 now ? I'm yet to go through the series; I'll get to it in a day or two. Am

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-16 Thread Greg Kurz
On Fri, 13 Jun 2014 13:56:13 +0200 Alexander Graf wrote: > > On 13.06.14 13:18, Greg Kurz wrote: > > Hi, > > > > This version merges the changes requested during the v7 review, remarks from > > ppc64 dump support review (yes, we talked about virtio there) and the work > > on > > virtio subsectio

Re: [Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-13 Thread Alexander Graf
On 13.06.14 13:18, Greg Kurz wrote: Hi, This version merges the changes requested during the v7 review, remarks from ppc64 dump support review (yes, we talked about virtio there) and the work on virtio subsections migration. Also two new patches have been added: - patch #1 is a preliminary fix

[Qemu-devel] [PATCH v8 00/20] virtio endian-ambivalent target

2014-06-13 Thread Greg Kurz
Hi, This version merges the changes requested during the v7 review, remarks from ppc64 dump support review (yes, we talked about virtio there) and the work on virtio subsections migration. Also two new patches have been added: - patch #1 is a preliminary fix for virtio-serial posted by Alexander G