Re: [Qemu-devel] [PATCH v8 0/2] Implement Hex file loader and add test case

2018-05-15 Thread Stefan Hajnoczi
On Tue, May 15, 2018 at 09:45:56AM +0800, Su Hang wrote: > These series of patchs implement Intel Hexadecimal File loader and > add QTest testcase to verify the correctness of Loader. Good job, this looks close now. I left a comment on the test case - it needs to work with out-of-tree builds. St

[Qemu-devel] [PATCH v8 0/2] Implement Hex file loader and add test case

2018-05-14 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. v1: -- Basic version. v2: -- Replace `do{}while(cond);` block with `for(;;)` block. v3: -- Add two new files information in MAINTAINERS. v4: -- Correct the 'test.hex' p

[Qemu-devel] [PATCH v8 0/2] Implement Hex file loader and add test case

2018-05-10 Thread Su Hang
These series of patchs implement Intel Hexadecimal File loader and add QTest testcase to verify the correctness of Loader. v1: -- Basic version. v2: -- Replace `do{}while(cond);` block with `for(;;)` block. v3: -- Add two new files information in MAINTAINERS. v4: -- Correct the 'test.hex' p