[Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error

2017-06-26 Thread Mao Zhongyi
In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi Reviewed-by: Marcel Apfelbaum --- hw/pci-bridge/pci_bridge_dev.c | 14 ++--

Re: [Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error

2017-06-25 Thread Mao Zhongyi
On 06/23/2017 05:56 PM, Marcel Apfelbaum wrote: On 22/06/2017 11:14, Mao Zhongyi wrote: In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by:

Re: [Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error

2017-06-23 Thread Marcel Apfelbaum
On 22/06/2017 11:14, Mao Zhongyi wrote: In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- v7: * drop the !local_err assert i

[Qemu-devel] [PATCH v7 7/9] pci: Convert shpc_init() to Error

2017-06-22 Thread Mao Zhongyi
In order to propagate error message better, convert shpc_init() to Error also convert the pci_bridge_dev_initfn() to realize. Cc: m...@redhat.com Cc: mar...@redhat.com Cc: arm...@redhat.com Signed-off-by: Mao Zhongyi --- v7: * drop the !local_err assert is really not appropriate, now revert it.