Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-09-24 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > "Dr. David Alan Gilbert (git)" wrote: > > From: "Dr. David Alan Gilbert" > > > > Userfault doesn't work with mlock; mlock is designed to nail down pages > > so they don't move, userfault is designed to tell you when they're not > > there. > > > > mun

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-08-06 Thread zhanghailiang
On 2015/8/6 22:55, Dr. David Alan Gilbert wrote: * Juan Quintela (quint...@redhat.com) wrote: Amit Shah wrote: On (Tue) 14 Jul 2015 [17:22:13], Juan Quintela wrote: "Dr. David Alan Gilbert (git)" wrote: +if (enable_mlock) { +if (os_mlock() < 0) { +error_report("mlo

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-08-06 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Amit Shah wrote: > > On (Tue) 14 Jul 2015 [17:22:13], Juan Quintela wrote: > >> "Dr. David Alan Gilbert (git)" wrote: > > > >> > +if (enable_mlock) { > >> > +if (os_mlock() < 0) { > >> > +error_report("mlock: %s", strerror(err

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-28 Thread Juan Quintela
Amit Shah wrote: > On (Tue) 14 Jul 2015 [17:22:13], Juan Quintela wrote: >> "Dr. David Alan Gilbert (git)" wrote: > >> > +if (enable_mlock) { >> > +if (os_mlock() < 0) { >> > +error_report("mlock: %s", strerror(errno)); >> > +/* >> > + * It doesn't

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-27 Thread Amit Shah
On (Tue) 16 Jun 2015 [11:26:54], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Userfault doesn't work with mlock; mlock is designed to nail down pages > so they don't move, userfault is designed to tell you when they're not > there. > > munlock the pages we userfault p

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-27 Thread Amit Shah
On (Tue) 14 Jul 2015 [17:22:13], Juan Quintela wrote: > "Dr. David Alan Gilbert (git)" wrote: > > +if (enable_mlock) { > > +if (os_mlock() < 0) { > > +error_report("mlock: %s", strerror(errno)); > > +/* > > + * It doesn't feel right to fail at this

Re: [Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-07-14 Thread Juan Quintela
"Dr. David Alan Gilbert (git)" wrote: > From: "Dr. David Alan Gilbert" > > Userfault doesn't work with mlock; mlock is designed to nail down pages > so they don't move, userfault is designed to tell you when they're not > there. > > munlock the pages we userfault protect before postcopy. > mlock

[Qemu-devel] [PATCH v7 41/42] Disable mlock around incoming postcopy

2015-06-16 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Userfault doesn't work with mlock; mlock is designed to nail down pages so they don't move, userfault is designed to tell you when they're not there. munlock the pages we userfault protect before postcopy. mlock everything again at the end if mlock is enabled. Sig