Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-19 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > "Dr. David Alan Gilbert" writes: > > > * Markus Armbruster (arm...@redhat.com) wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: > >> >> Daniel P. Berrangé writes: > >> >> > >>

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-19 Thread Markus Armbruster
"Dr. David Alan Gilbert" writes: > * Markus Armbruster (arm...@redhat.com) wrote: >> Daniel P. Berrangé writes: >> >> > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: >> >> Daniel P. Berrangé writes: >> >> >> >> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote:

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-05 Thread Dr. David Alan Gilbert
* Markus Armbruster (arm...@redhat.com) wrote: > Daniel P. Berrangé writes: > > > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > >> >> On 09/03/2018 08:31 AM, Markus Arm

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-04 Thread Peter Xu
On Tue, Sep 04, 2018 at 10:04:00AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > On Mon, Sep 03, 2018 at 03:41:16PM +0100, Daniel P. Berrangé wrote: > >> On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > >> > On 09/03/2018 08:31 AM, Markus Armbruster wrote: > >> > > >> > >

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-04 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: >> Daniel P. Berrangé writes: >> >> > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: >> >> On 09/03/2018 08:31 AM, Markus Armbruster wrote: >> >> >> >> > Example: >> >> > >> >> >

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-04 Thread Daniel P . Berrangé
On Tue, Sep 04, 2018 at 08:39:27AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > >> On 09/03/2018 08:31 AM, Markus Armbruster wrote: > >> > >> > Example: > >> > > >> > client sends in-band command #1 > >> >

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-04 Thread Markus Armbruster
Peter Xu writes: > On Mon, Sep 03, 2018 at 03:41:16PM +0100, Daniel P. Berrangé wrote: >> On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: >> > On 09/03/2018 08:31 AM, Markus Armbruster wrote: >> > >> > > Example: >> > > >> > > client sends in-band command #1 >> > > QEMU re

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: >> On 09/03/2018 08:31 AM, Markus Armbruster wrote: >> >> > Example: >> > >> > client sends in-band command #1 >> > QEMU reads and queues >> > QEMU dequeues in-band command #1 >> > in-ba

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Peter Xu
On Mon, Sep 03, 2018 at 03:41:16PM +0100, Daniel P. Berrangé wrote: > On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > > On 09/03/2018 08:31 AM, Markus Armbruster wrote: > > > > > Example: > > > > > > client sends in-band command #1 > > > QEMU reads and queues > > > QE

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Daniel P . Berrangé
On Mon, Sep 03, 2018 at 09:30:52AM -0500, Eric Blake wrote: > On 09/03/2018 08:31 AM, Markus Armbruster wrote: > > > Example: > > > > client sends in-band command #1 > > QEMU reads and queues > > QEMU dequeues in-band command #1 > > in-band command #1 starts executing, but it'

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Eric Blake
On 09/03/2018 08:31 AM, Markus Armbruster wrote: Example: client sends in-band command #1 QEMU reads and queues QEMU dequeues in-band command #1 in-band command #1 starts executing, but it's slooow client sends in-band command #2 QEMU reads and queues ...

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Markus Armbruster
Cc: Eric & Daniel for the libvirt point of view. Peter Xu writes: > On Mon, Sep 03, 2018 at 09:49:13AM +0200, Markus Armbruster wrote: >> Peter Xu writes: >> >> > Now it was not used any more, drop it. We can still do that since >> > out-of-band is still experimental, and this event is only u

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Peter Xu
On Mon, Sep 03, 2018 at 09:49:13AM +0200, Markus Armbruster wrote: > Peter Xu writes: > > > Now it was not used any more, drop it. We can still do that since > > out-of-band is still experimental, and this event is only used when > > out-of-band is enabled. > > > > Signed-off-by: Peter Xu > > -

Re: [Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-03 Thread Markus Armbruster
Peter Xu writes: > Now it was not used any more, drop it. We can still do that since > out-of-band is still experimental, and this event is only used when > out-of-band is enabled. > > Signed-off-by: Peter Xu > --- > docs/interop/qmp-spec.txt | 5 +++-- > qapi/misc.json| 40 --

[Qemu-devel] [PATCH v7 4/7] qapi: remove COMMAND_DROPPED event

2018-09-02 Thread Peter Xu
Now it was not used any more, drop it. We can still do that since out-of-band is still experimental, and this event is only used when out-of-band is enabled. Signed-off-by: Peter Xu --- docs/interop/qmp-spec.txt | 5 +++-- qapi/misc.json| 40 ---