Re: [Qemu-devel] [PATCH v7 25/39] qapi: Require valid names

2015-05-04 Thread Markus Armbruster
Eric Blake writes: > On 04/29/2015 07:06 AM, Eric Blake wrote: >> Previous commits demonstrated that the generator overlooked various >> bad naming situations: >> - types, commands, and events need a valid name >> - enum members must be valid names, when combined with prefix >> - union and altern

Re: [Qemu-devel] [PATCH v7 25/39] qapi: Require valid names

2015-05-02 Thread Eric Blake
On 04/29/2015 07:06 AM, Eric Blake wrote: > Previous commits demonstrated that the generator overlooked various > bad naming situations: > - types, commands, and events need a valid name > - enum members must be valid names, when combined with prefix > - union and alternate branches cannot be marke

[Qemu-devel] [PATCH v7 25/39] qapi: Require valid names

2015-04-29 Thread Eric Blake
Previous commits demonstrated that the generator overlooked various bad naming situations: - types, commands, and events need a valid name - enum members must be valid names, when combined with prefix - union and alternate branches cannot be marked optional Valid upstream names match [a-zA-Z][a-zA