Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2019-01-04 Thread Cornelia Huck
On Fri, 4 Jan 2019 14:57:26 +0400 Marc-André Lureau wrote: > Hi > > On Fri, Dec 21, 2018 at 7:34 PM Cornelia Huck wrote: > > > > On Fri, 21 Dec 2018 13:04:07 +0400 > > Marc-André Lureau wrote: > > > > > All qdev_prop_register_global() set &error_fatal for errp, except > > > '-rtc driftfix=sl

Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2019-01-04 Thread Marc-André Lureau
Hi On Fri, Dec 21, 2018 at 7:34 PM Cornelia Huck wrote: > > On Fri, 21 Dec 2018 13:04:07 +0400 > Marc-André Lureau wrote: > > > All qdev_prop_register_global() set &error_fatal for errp, except > > '-rtc driftfix=slew', which arguably should also use &error_fatal, as > > otherwise failing to app

Re: [Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2018-12-21 Thread Cornelia Huck
On Fri, 21 Dec 2018 13:04:07 +0400 Marc-André Lureau wrote: > All qdev_prop_register_global() set &error_fatal for errp, except > '-rtc driftfix=slew', which arguably should also use &error_fatal, as > otherwise failing to apply the property would only report a warning. > > Signed-off-by: Marc-A

[Qemu-devel] [PATCH v7 25/28] qdev-props: remove errp from GlobalProperty

2018-12-21 Thread Marc-André Lureau
All qdev_prop_register_global() set &error_fatal for errp, except '-rtc driftfix=slew', which arguably should also use &error_fatal, as otherwise failing to apply the property would only report a warning. Signed-off-by: Marc-André Lureau Reviewed-by: Igor Mammedov --- include/hw/qdev-core.h