Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-09-01 Thread Stefan Hajnoczi
On Fri, Aug 29, 2014 at 05:59:37PM +0200, Paolo Bonzini wrote: > Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto: > > for (i = 0; i < 8; ++i) { > > quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i); > > } > > if (qtest_big_endian() != qtest_host_endian()) { > > quad.u64 = bswap64(quad.u64)

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
El Fri, 29 Aug 2014 17:59:37 +0200 Paolo Bonzini escribió: > Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto: > > for (i = 0; i < 8; ++i) { > > quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i); > > } > > if (qtest_big_endian() != qtest_host_endian()) { > > quad.u64 = bswap64(quad.u64); >

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
El Fri, 29 Aug 2014 16:49:36 +0100 Stefan Hajnoczi escribió: > On Fri, Aug 29, 2014 at 12:40:43PM +0200, Marc Marí wrote: > > +static uint64_t qvirtio_pci_config_readq(QVirtioDevice *d, void > > *addr) +{ > > +QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d; > > +int i; > > +union { > >

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Paolo Bonzini
Il 29/08/2014 17:49, Stefan Hajnoczi ha scritto: > for (i = 0; i < 8; ++i) { > quad.bytes[i] = qpci_io_readb(dev->pdev, addr + i); > } > if (qtest_big_endian() != qtest_host_endian()) { > quad.u64 = bswap64(quad.u64); > } > return quard.u64; Why not keep the logic in Marc's patch, just rep

Re: [Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Stefan Hajnoczi
On Fri, Aug 29, 2014 at 12:40:43PM +0200, Marc Marí wrote: > +static uint64_t qvirtio_pci_config_readq(QVirtioDevice *d, void *addr) > +{ > +QVirtioPCIDevice *dev = (QVirtioPCIDevice *)d; > +int i; > +union { > +uint8_t bytes[8]; > +uint64_t u64; > +} quad; > + > +

[Qemu-devel] [PATCH v7 2/7] tests: Add virtio device initialization

2014-08-29 Thread Marc Marí
Add functions to read and write virtio header fields. Add status bit setting in virtio-blk-device. Signed-off-by: Marc Marí --- tests/Makefile|2 +- tests/libqos/virtio-pci.c | 73 + tests/libqos/virtio-pci.h | 18 +++ tests