Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-18 Thread Pradeep Kiruvale
On Aug 16, 2017 11:41 PM, "Markus Armbruster" wrote: Eric Blake writes: > On 08/16/2017 11:13 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> > >>> >>> Conclusion: no consensus, yet. >> >> All right, let's start over and try to resolve the impasse and/or >> misunderstanding. >> >>

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-16 Thread Markus Armbruster
Eric Blake writes: > On 08/16/2017 11:13 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> > >>> >>> Conclusion: no consensus, yet. >> >> All right, let's start over and try to resolve the impasse and/or >> misunderstanding. >> >> Type BlockIOThrottle lives in qapi/block-core.json,

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-16 Thread Eric Blake
On 08/16/2017 11:13 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> >> Conclusion: no consensus, yet. > > All right, let's start over and try to resolve the impasse and/or > misunderstanding. > > Type BlockIOThrottle lives in qapi/block-core.json, and is used by QMP > command blo

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-16 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> On 08/10/2017 09:06 AM, Pradeep Jagadeesh wrote: >> > It's not "moving it back", it's keeping it where it is. But I see no big > problem with moving it to a common file either. I'd rather not put every struct shared across sub

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-10 Thread Markus Armbruster
Eric Blake writes: > On 08/10/2017 09:06 AM, Pradeep Jagadeesh wrote: > It's not "moving it back", it's keeping it where it is. But I see no big problem with moving it to a common file either. >>> >>> I'd rather not put every struct shared across subsystem boundaries in >>> its own file

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-10 Thread Eric Blake
On 08/10/2017 09:06 AM, Pradeep Jagadeesh wrote: >>> It's not "moving it back", it's keeping it where it is. But I see no big >>> problem with moving it to a common file either. >> >> I'd rather not put every struct shared across subsystem boundaries in >> its own file. >> >> We can keep it right

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-10 Thread Pradeep Jagadeesh
On 8/8/2017 5:18 PM, Markus Armbruster wrote: Alberto Garcia writes: On Tue 08 Aug 2017 02:30:43 PM CEST, Pradeep Jagadeesh wrote: On 8/8/2017 1:30 PM, Alberto Garcia wrote: On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: Awkward question for a v7, but here goes anyway: why is

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Markus Armbruster
Alberto Garcia writes: > On Tue 08 Aug 2017 02:30:43 PM CEST, Pradeep Jagadeesh wrote: >> On 8/8/2017 1:30 PM, Alberto Garcia wrote: >>> On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: >> Awkward question for a v7, but here goes anyway: why is IOThrottle >> worth its very ow

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Alberto Garcia
On Tue 08 Aug 2017 02:30:43 PM CEST, Pradeep Jagadeesh wrote: > On 8/8/2017 1:30 PM, Alberto Garcia wrote: >> On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: > Awkward question for a v7, but here goes anyway: why is IOThrottle > worth its very own .json file? I feel this

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Pradeep Jagadeesh
On 8/8/2017 1:30 PM, Alberto Garcia wrote: On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: Awkward question for a v7, but here goes anyway: why is IOThrottle worth its very own .json file? I feel this is a common throttle structure that is used by block devices as well as fsdev, s

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-08 Thread Alberto Garcia
On Mon 07 Aug 2017 04:48:38 PM CEST, Markus Armbruster wrote: >>> Awkward question for a v7, but here goes anyway: why is IOThrottle >>> worth its very own .json file? >> I feel this is a common throttle structure that is used by block >> devices as well as fsdev, so moved to a separate file. > I'm

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-07 Thread Markus Armbruster
Pradeep Jagadeesh writes: > On 7/6/2017 7:55 PM, Markus Armbruster wrote: >> Pradeep Jagadeesh writes: >> >>> This patch enables qmp interfaces for the fsdev >>> devices. This provides two interfaces one >>> for querying info of all the fsdev devices. The second one >>> to set the IO limits for

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-08-07 Thread Pradeep Jagadeesh
On 7/6/2017 7:55 PM, Markus Armbruster wrote: Pradeep Jagadeesh writes: This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Prade

Re: [Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-07-06 Thread Markus Armbruster
Pradeep Jagadeesh writes: > This patch enables qmp interfaces for the fsdev > devices. This provides two interfaces one > for querying info of all the fsdev devices. The second one > to set the IO limits for the required fsdev device. > > Signed-off-by: Pradeep Jagadeesh > Reviewed-by: Greg Kur

[Qemu-devel] [PATCH v7 2/6] qmp: Create IOThrottle structure

2017-07-04 Thread Pradeep Jagadeesh
This patch enables qmp interfaces for the fsdev devices. This provides two interfaces one for querying info of all the fsdev devices. The second one to set the IO limits for the required fsdev device. Signed-off-by: Pradeep Jagadeesh Reviewed-by: Greg Kurz Reviewed-by: Eric Blake Reviewed-by: