Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Amador Pahim
On Tue, Aug 22, 2017 at 1:56 PM, Fam Zheng wrote: > On Tue, 08/22 13:11, Amador Pahim wrote: >> I don't think that the 'keep the behavior' principle should overcome >> what the messages actually are. The question is: are they warning >> messages? The way I see, the messages I changed in this commi

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Fam Zheng
On Tue, 08/22 13:11, Amador Pahim wrote: > I don't think that the 'keep the behavior' principle should overcome > what the messages actually are. The question is: are they warning > messages? The way I see, the messages I changed in this commit to use > the logging system are both debug messages.

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Amador Pahim
On Tue, Aug 22, 2017 at 12:24 PM, Fam Zheng wrote: > On Fri, 08/18 19:05, Amador Pahim wrote: >> This module should not write directly to stdout/stderr. Instead, it >> should either raise exceptions or just log the messages and let the >> callers handle them and decide what to do. For example, scr

Re: [Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-22 Thread Fam Zheng
On Fri, 08/18 19:05, Amador Pahim wrote: > This module should not write directly to stdout/stderr. Instead, it > should either raise exceptions or just log the messages and let the > callers handle them and decide what to do. For example, scripts could > choose to send the log messages stderr or/an

[Qemu-devel] [PATCH v7 02/11] qemu.py: avoid writing to stdout/stderr

2017-08-18 Thread Amador Pahim
This module should not write directly to stdout/stderr. Instead, it should either raise exceptions or just log the messages and let the callers handle them and decide what to do. For example, scripts could choose to send the log messages stderr or/and write them to a file if verbose or debugging mo