Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

2016-06-17 Thread Markus Armbruster
Eric Blake writes: > On 06/16/2016 08:46 AM, Markus Armbruster wrote: >> Markus Armbruster writes: >> >>> Eric Blake writes: >>> Rather than having two separate visitor callbacks with items already broken out, pass the actual QAPISchemaObjectType object to the visitor. This let

Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

2016-06-16 Thread Eric Blake
On 06/16/2016 08:46 AM, Markus Armbruster wrote: > Markus Armbruster writes: > >> Eric Blake writes: >> >>> Rather than having two separate visitor callbacks with items >>> already broken out, pass the actual QAPISchemaObjectType object >>> to the visitor. This lets the visitor access things li

Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

2016-06-16 Thread Markus Armbruster
Markus Armbruster writes: > Eric Blake writes: > >> Rather than having two separate visitor callbacks with items >> already broken out, pass the actual QAPISchemaObjectType object >> to the visitor. This lets the visitor access things like >> type.is_implicit() without needing another parameter

Re: [Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

2016-06-14 Thread Markus Armbruster
Eric Blake writes: > Rather than having two separate visitor callbacks with items > already broken out, pass the actual QAPISchemaObjectType object > to the visitor. This lets the visitor access things like > type.is_implicit() without needing another parameter, resolving > a TODO from previous

[Qemu-devel] [PATCH v7 01/15] qapi: Consolidate object visitors

2016-05-20 Thread Eric Blake
Rather than having two separate visitor callbacks with items already broken out, pass the actual QAPISchemaObjectType object to the visitor. This lets the visitor access things like type.is_implicit() without needing another parameter, resolving a TODO from previous patches. For convenience and c