Re: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

2016-09-05 Thread Fam Zheng
On Mon, 08/08 21:13, Fam Zheng wrote: > v7: - Rebase. > - Address comments from Kevin and Max. > - Option rename: "exclusive" -> "auto". [Kevin] > - Option placement: "root BDS" -> "node". > It's still a bit controversy where the option should go, but so far it > seems per n

Re: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

2016-08-08 Thread Fam Zheng
On Mon, 08/08 06:59, no-re...@ec2-52-6-146-230.compute-1.amazonaws.com wrote: > Checking PATCH 3/20: block: Add and parse "lock-mode" option for image > locking... > ERROR: do not use assignment in if condition > #80: FILE: blockdev.c:548: > +if ((buf = qemu_opt_get(opts, BDRV_OPT_LOCK_MODE))

Re: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

2016-08-08 Thread no-reply
Hi, Your series seems to have some coding style problems. See output below for more information: Message-id: 1470662013-19785-1-git-send-email-f...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8 === TEST SCRIPT BEGIN === #!/bin/bash BASE=base

[Qemu-devel] [PATCH v7 00/20] block: Image locking series for 2.8

2016-08-08 Thread Fam Zheng
v7: - Rebase. - Address comments from Kevin and Max. - Option rename: "exclusive" -> "auto". [Kevin] - Option placement: "root BDS" -> "node". It's still a bit controversy where the option should go, but so far it seems per node is the safest. - Assert in bdrv_open_commo