Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova I started re-reviewing this, but my suggestions quickly became a rewrite (sorry), so I'm just posting just that. I'll turn it into a proper patch you can include in your serie

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Markus Armbruster writes: >>> Lluís Vilanova writes: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova > --- > HACKING | 37

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Markus Armbruster writes: >> >>> Lluís Vilanova writes: Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 37 + 1 file

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Markus Armbruster
Lluís Vilanova writes: > Markus Armbruster writes: > >> Lluís Vilanova writes: >>> Gives some general guidelines for reporting errors in QEMU. >>> >>> Signed-off-by: Lluís Vilanova >>> --- >>> HACKING | 37 + >>> 1 file changed, 37 insertions(+) >>> >>> di

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-03 Thread Lluís Vilanova
Markus Armbruster writes: > Lluís Vilanova writes: >> Gives some general guidelines for reporting errors in QEMU. >> >> Signed-off-by: Lluís Vilanova >> --- >> HACKING | 37 + >> 1 file changed, 37 insertions(+) >> >> diff --git a/HACKING b/HACKING >> index

Re: [Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-02 Thread Markus Armbruster
Lluís Vilanova writes: > Gives some general guidelines for reporting errors in QEMU. > > Signed-off-by: Lluís Vilanova > --- > HACKING | 37 + > 1 file changed, 37 insertions(+) > > diff --git a/HACKING b/HACKING > index 12fbc8a..b738bce 100644 > --- a/HACK

[Qemu-devel] [PATCH v6 5/5] doc: Introduce coding style for errors

2016-02-02 Thread Lluís Vilanova
Gives some general guidelines for reporting errors in QEMU. Signed-off-by: Lluís Vilanova --- HACKING | 37 + 1 file changed, 37 insertions(+) diff --git a/HACKING b/HACKING index 12fbc8a..b738bce 100644 --- a/HACKING +++ b/HACKING @@ -157,3 +157,40 @@ pain