Re: [Qemu-devel] [PATCH v6 35/42] block: Fix check_to_replace_node()

2019-08-16 Thread Vladimir Sementsov-Ogievskiy
16.08.2019 16:30, Max Reitz wrote: > On 16.08.19 13:01, Vladimir Sementsov-Ogievskiy wrote: >> 15.08.2019 20:01, Max Reitz wrote: >>> On 15.08.19 17:21, Vladimir Sementsov-Ogievskiy wrote: 09.08.2019 19:14, Max Reitz wrote: > Currently, check_to_replace_node() only allows mirror to replace

Re: [Qemu-devel] [PATCH v6 35/42] block: Fix check_to_replace_node()

2019-08-16 Thread Max Reitz
On 16.08.19 13:01, Vladimir Sementsov-Ogievskiy wrote: > 15.08.2019 20:01, Max Reitz wrote: >> On 15.08.19 17:21, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:14, Max Reitz wrote: Currently, check_to_replace_node() only allows mirror to replace a node in the chain of the source n

Re: [Qemu-devel] [PATCH v6 35/42] block: Fix check_to_replace_node()

2019-08-16 Thread Vladimir Sementsov-Ogievskiy
15.08.2019 20:01, Max Reitz wrote: > On 15.08.19 17:21, Vladimir Sementsov-Ogievskiy wrote: >> 09.08.2019 19:14, Max Reitz wrote: >>> Currently, check_to_replace_node() only allows mirror to replace a node >>> in the chain of the source node, and only if it is the first non-filter >>> node below th

Re: [Qemu-devel] [PATCH v6 35/42] block: Fix check_to_replace_node()

2019-08-15 Thread Max Reitz
On 15.08.19 17:21, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:14, Max Reitz wrote: >> Currently, check_to_replace_node() only allows mirror to replace a node >> in the chain of the source node, and only if it is the first non-filter >> node below the source. Well, technically, the idea is

Re: [Qemu-devel] [PATCH v6 35/42] block: Fix check_to_replace_node()

2019-08-15 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:14, Max Reitz wrote: > Currently, check_to_replace_node() only allows mirror to replace a node > in the chain of the source node, and only if it is the first non-filter > node below the source. Well, technically, the idea is that you can > exactly replace a quorum child by mirroring

[Qemu-devel] [PATCH v6 35/42] block: Fix check_to_replace_node()

2019-08-09 Thread Max Reitz
Currently, check_to_replace_node() only allows mirror to replace a node in the chain of the source node, and only if it is the first non-filter node below the source. Well, technically, the idea is that you can exactly replace a quorum child by mirroring from quorum. This has (probably) two reaso