Re: [Qemu-devel] [PATCH v6 3/5] sockets: use error class to pass connect error

2012-04-18 Thread Orit Wasserman
On 04/17/2012 05:54 PM, Amos Kong wrote: > Add a new argument in inet_connect()/inet_connect_opts() > to pass back connect error. > > Change nbd, vnc to use new interface. > > Signed-off-by: Amos Kong > --- > nbd.c |2 +- > qemu-char.c|2 +- > qemu-sockets.c | 13

Re: [Qemu-devel] [PATCH v6 3/5] sockets: use error class to pass connect error

2012-04-17 Thread Michael Roth
On Tue, Apr 17, 2012 at 10:54:20PM +0800, Amos Kong wrote: > Add a new argument in inet_connect()/inet_connect_opts() > to pass back connect error. > > Change nbd, vnc to use new interface. Looks good! Reviewed-by: Michael Roth > > Signed-off-by: Amos Kong > --- > nbd.c |2 +- >

[Qemu-devel] [PATCH v6 3/5] sockets: use error class to pass connect error

2012-04-17 Thread Amos Kong
Add a new argument in inet_connect()/inet_connect_opts() to pass back connect error. Change nbd, vnc to use new interface. Signed-off-by: Amos Kong --- nbd.c |2 +- qemu-char.c|2 +- qemu-sockets.c | 13 ++--- qemu_socket.h |6 -- ui/vnc.c |2 +-