Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Kevin Wolf
Am 13.11.2015 um 12:19 hat Wen Congyang geschrieben: > On 11/13/2015 06:53 PM, Kevin Wolf wrote: > > Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: > >> On 11/10/2015 09:40 AM, Wen Congyang wrote: > >>> On 11/10/2015 12:04 AM, Kevin Wolf wrote: > Am 16.10.2015 um 10:57 hat Wen Congyang g

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Wen Congyang
On 11/13/2015 06:53 PM, Kevin Wolf wrote: > Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: >> On 11/10/2015 09:40 AM, Wen Congyang wrote: >>> On 11/10/2015 12:04 AM, Kevin Wolf wrote: Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: > +## > +# @ChangeOperation: > +# >

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Kevin Wolf
Am 13.11.2015 um 11:25 hat Wen Congyang geschrieben: > On 11/10/2015 09:40 AM, Wen Congyang wrote: > > On 11/10/2015 12:04 AM, Kevin Wolf wrote: > >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: > >>> +## > >>> +# @ChangeOperation: > >>> +# > >>> +# An enumeration of block device change ope

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-13 Thread Wen Congyang
On 11/10/2015 09:40 AM, Wen Congyang wrote: > On 11/10/2015 12:04 AM, Kevin Wolf wrote: >> Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: >>> +## >>> +# @ChangeOperation: >>> +# >>> +# An enumeration of block device change operation. >>> +# >>> +# @add: Add a new block driver state to a exist

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-10 Thread Markus Armbruster
Wen Congyang writes: > On 11/09/2015 10:42 PM, Alberto Garcia wrote: >> Sorry again for the late review, here are my comments: >> >> On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: >>> +void qmp_x_blockdev_change(ChangeOperation op, const char *parent, >>> + bo

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-09 Thread Wen Congyang
On 11/09/2015 10:42 PM, Alberto Garcia wrote: > Sorry again for the late review, here are my comments: > > On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: >> +void qmp_x_blockdev_change(ChangeOperation op, const char *parent, >> + bool has_child, const char *chil

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-09 Thread Wen Congyang
On 11/10/2015 12:04 AM, Kevin Wolf wrote: > Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: >> +## >> +# @ChangeOperation: >> +# >> +# An enumeration of block device change operation. >> +# >> +# @add: Add a new block driver state to a existed block driver state. >> +# >> +# @delete: Delete a

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-09 Thread Kevin Wolf
Am 16.10.2015 um 10:57 hat Wen Congyang geschrieben: > +## > +# @ChangeOperation: > +# > +# An enumeration of block device change operation. > +# > +# @add: Add a new block driver state to a existed block driver state. > +# > +# @delete: Delete a block driver state's child. > +# > +# Since: 2.5 > +

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-09 Thread Alberto Garcia
Sorry again for the late review, here are my comments: On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: > +void qmp_x_blockdev_change(ChangeOperation op, const char *parent, > + bool has_child, const char *child, > + bool has_new_node, co

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-05 Thread Wen Congyang
On 11/05/2015 09:49 PM, Alberto Garcia wrote: > On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang > wrote: > >> The new QMP command name is x-blockdev-change. It justs for >> adding/removing quorum's child now, and don't support all kinds of >> children, all kinds of operations, nor all block dr

Re: [Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-11-05 Thread Alberto Garcia
On Fri 16 Oct 2015 10:57:45 AM CEST, Wen Congyang wrote: > The new QMP command name is x-blockdev-change. It justs for > adding/removing quorum's child now, and don't support all kinds of > children, all kinds of operations, nor all block drivers. So it is > experimental now. I might have missed

[Qemu-devel] [PATCH v6 3/4] qmp: add monitor command to add/remove a child

2015-10-16 Thread Wen Congyang
The new QMP command name is x-blockdev-change. It justs for adding/removing quorum's child now, and don't support all kinds of children, all kinds of operations, nor all block drivers. So it is experimental now. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei ---