Re: [Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-25 Thread David Marchand
On 09/23/2014 05:58 PM, Stefan Hajnoczi wrote: I'm not sure a full-fledged feature negotiation system is needed. The ivshmem protocol is local to the host and all participants are under control of the administrator. I suggested a protocol version to protect against misconfiguration. For exampl

Re: [Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-23 Thread Stefan Hajnoczi
On Mon, Sep 08, 2014 at 12:49:48PM +0300, Michael S. Tsirkin wrote: > On Mon, Sep 08, 2014 at 11:17:50AM +0200, David Marchand wrote: > > Send a protocol version as the first message from server, clients must close > > communication if they don't support this protocol version. > > What's the motiv

Re: [Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-08 Thread Michael S. Tsirkin
On Mon, Sep 08, 2014 at 11:17:50AM +0200, David Marchand wrote: > Send a protocol version as the first message from server, clients must close > communication if they don't support this protocol version. What's the motivation here? This is at best a way to break all clients if an incompatible chan

[Qemu-devel] [PATCH v6 3/3] ivshmem: add check on protocol version in QEMU

2014-09-08 Thread David Marchand
Send a protocol version as the first message from server, clients must close communication if they don't support this protocol version. Older QEMUs should be fine with this change in the protocol since they overrides their own vm_id on reception of an id associated to no eventfd. Signed-off-by: Da