Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Paolo Bonzini
Il 05/02/2014 16:52, Andreas Färber ha scritto: > +object_property_add_link(obj, QDEV_HOTPLUG_HANDLER_PROPERTY, > + TYPE_HOTPLUG_HANDLER, > + (Object **)&bus->hotplug_handler, NULL); Will/should the user ever change that property? If no

Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Igor Mammedov
On Wed, 05 Feb 2014 16:52:27 +0100 Andreas Färber wrote: > Am 05.02.2014 16:36, schrieb Igor Mammedov: > > It will allow to reuse field with different BUSes, > > reducing code duplication. Field is intended for > > replacing 'hotplug_qdev' field in PCIBus and also > > will allow to avoid adding e

Re: [Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Andreas Färber
Am 05.02.2014 16:36, schrieb Igor Mammedov: > It will allow to reuse field with different BUSes, > reducing code duplication. Field is intended for > replacing 'hotplug_qdev' field in PCIBus and also > will allow to avoid adding equivalent field to > DimmBus with possiblitity to refactor other BUSe

[Qemu-devel] [PATCH v6 2/9] qdev: add to BusState "hotplug-handler" link

2014-02-05 Thread Igor Mammedov
It will allow to reuse field with different BUSes, reducing code duplication. Field is intended for replacing 'hotplug_qdev' field in PCIBus and also will allow to avoid adding equivalent field to DimmBus with possiblitity to refactor other BUSes to use it instead of custom field. In addition once