Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-09 Thread Max Reitz
On 09.09.19 12:01, Kevin Wolf wrote: > Am 09.09.2019 um 10:31 hat Max Reitz geschrieben: >> On 05.09.19 18:24, Kevin Wolf wrote: >>> Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the d

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 10:31 hat Max Reitz geschrieben: > On 05.09.19 18:24, Kevin Wolf wrote: > > Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: > >> On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > >>> 09.08.2019 19:13, Max Reitz wrote: > If the driver does not support .bdrv_co_flush()

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-09 Thread Max Reitz
On 05.09.19 18:24, Kevin Wolf wrote: > Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: >> On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: >>> 09.08.2019 19:13, Max Reitz wrote: If the driver does not support .bdrv_co_flush() so bdrv_co_flush() itself has to flush the children of

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-09-05 Thread Kevin Wolf
Am 12.08.2019 um 14:58 hat Max Reitz geschrieben: > On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > > 09.08.2019 19:13, Max Reitz wrote: > >> If the driver does not support .bdrv_co_flush() so bdrv_co_flush() > >> itself has to flush the children of the given node, it should not flush > >>

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-08-12 Thread Max Reitz
On 10.08.19 17:36, Vladimir Sementsov-Ogievskiy wrote: > 09.08.2019 19:13, Max Reitz wrote: >> If the driver does not support .bdrv_co_flush() so bdrv_co_flush() >> itself has to flush the children of the given node, it should not flush >> just bs->file->bs, but in fact all children. >> >> In any c

Re: [Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-08-10 Thread Vladimir Sementsov-Ogievskiy
09.08.2019 19:13, Max Reitz wrote: > If the driver does not support .bdrv_co_flush() so bdrv_co_flush() > itself has to flush the children of the given node, it should not flush > just bs->file->bs, but in fact all children. > > In any case, the BLKDBG_EVENT() should be emitted on the primary chil

[Qemu-devel] [PATCH v6 16/42] block: Flush all children in generic code

2019-08-09 Thread Max Reitz
If the driver does not support .bdrv_co_flush() so bdrv_co_flush() itself has to flush the children of the given node, it should not flush just bs->file->bs, but in fact all children. In any case, the BLKDBG_EVENT() should be emitted on the primary child, because that is where a blkdebug node woul