Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Kuo-Jung Su
2013/3/7 Peter Crosthwaite : > Hi Peter, Kuo-Jung, > > On Thu, Mar 7, 2013 at 12:28 PM, Peter Maydell > wrote: >> On 7 March 2013 10:18, Peter Crosthwaite >> wrote: >>> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in >>> v5, I realise the desire to fix this properly by re

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Kuo-Jung Su
2013/3/7 Peter Maydell : > On 7 March 2013 10:18, Peter Crosthwaite wrote: >> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in >> v5, I realise the desire to fix this properly by rewriting that >> if-else mess, but can we get a merge on this one more immediately to >> get QEM

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Peter Crosthwaite
Hi Peter, Kuo-Jung, On Thu, Mar 7, 2013 at 12:28 PM, Peter Maydell wrote: > On 7 March 2013 10:18, Peter Crosthwaite wrote: >> This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in >> v5, I realise the desire to fix this properly by rewriting that >> if-else mess, but can we get

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Peter Maydell
On 7 March 2013 10:18, Peter Crosthwaite wrote: > This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in > v5, I realise the desire to fix this properly by rewriting that > if-else mess, but can we get a merge on this one more immediately to > get QEMU working again? Rewriting this

Re: [Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-06 Thread Peter Crosthwaite
Hi Kuo Jung, Peter, This fixes a no-boot bug in u-boot for us as well. RE PMMs comments in v5, I realise the desire to fix this properly by rewriting that if-else mess, but can we get a merge on this one more immediately to get QEMU working again? Rewriting this is probably not at the top of eithe

[Qemu-devel] [PATCH v6 12/24] hw/nand.c: bug fix to erase operation

2013-03-05 Thread Kuo-Jung Su
The s->addr should be reset along with the s->addrlen, or it might have the previous address shifted to MSB and then causes problem to nand erase operation. Signed-off-by: Kuo-Jung Su --- hw/nand.c |1 + 1 file changed, 1 insertion(+) diff --git a/hw/nand.c b/hw/nand.c index 61e918f..6b2f2b