Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-17 Thread Greg Bellows
I fixed the issue by adding naming and a couple of macros for short-cutting the name. Interestingly and somewhat baffling, the only fields that needed the fix were the bank_fieldoffsets and fieldoffsets. It appears to be related to static initialization using these fields as all the CP15 anonymou

Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-17 Thread Greg Bellows
Good to know. Thanks Laurent. On Oct 17, 2014 10:27 AM, "Laurent Desnogues" wrote: > On Fri, Oct 17, 2014 at 5:20 PM, Greg Bellows > wrote: > > So, I believe I reproduced the issue with gcc-4.4. 4.6 and 4.7 appear to > > work fine. I tried adding the "-fms-extensions" flag through configure's

Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-17 Thread Laurent Desnogues
On Fri, Oct 17, 2014 at 5:20 PM, Greg Bellows wrote: > So, I believe I reproduced the issue with gcc-4.4. 4.6 and 4.7 appear to > work fine. I tried adding the "-fms-extensions" flag through configure's > "--extra-cflags" but it dow not appear to work. Not sure if this is a > configure/make iss

Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-17 Thread Greg Bellows
So, I believe I reproduced the issue with gcc-4.4. 4.6 and 4.7 appear to work fine. I tried adding the "-fms-extensions" flag through configure's "--extra-cflags" but it dow not appear to work. Not sure if this is a configure/make issue or if anonymous unions/structs are still disallowed. I'll

Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-17 Thread Greg Bellows
Hmmm, I had not encountered this as I am using a new compiler which is presumeably using -std=c11. Here is what I am using: > gcc --version gcc (Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1 A quick search on gcc 4.4 shows that a different flag may be needed (-fms-extensions). There is also a special fl

Re: [Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-16 Thread Edgar E. Iglesias
On Fri, Oct 10, 2014 at 11:03:22AM -0500, Greg Bellows wrote: > From: Fabian Aggeler > > Prepare ARMCPRegInfo to support specifying two fieldoffsets per > register definition. This will allow us to keep one register > definition for banked registers (different offsets for secure/ > non-secure wor

[Qemu-devel] [PATCH v6 11/32] target-arm: add CPREG secure state support

2014-10-10 Thread Greg Bellows
From: Fabian Aggeler Prepare ARMCPRegInfo to support specifying two fieldoffsets per register definition. This will allow us to keep one register definition for banked registers (different offsets for secure/ non-secure world). Also added secure state tracking field and flags. This allows for i