Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Gonglei (Arei)
Hi guys, Thanks for your good comments, we should come to an agreement on droping version filed In virtio crypto specific. And I'll update a new version soon. Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Tuesday, August 09, 2016 9:42 PM >

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Zeng, Xin
On Tuesday, August 9, 2016 6:58 PM Michael S. Tsirkin Wrote: > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Tuesday, August 9, 2016 6:58 PM > To: Zeng, Xin > Cc: Gonglei (Arei) ; qemu-devel@nongnu.org; > virtio-...@lists.oasis-open.org; Huangpeng (Peter) >

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Zeng, Xin
On Tuesday, August 9, 2016 6:44 PM Cornelia Huck wrote: > -Original Message- > From: Cornelia Huck [mailto:cornelia.h...@de.ibm.com] > Sent: Tuesday, August 9, 2016 6:44 PM > To: Zeng, Xin > Cc: Michael S. Tsirkin ; Gonglei (Arei) > ; qemu-devel@nongnu.org; virtio- > d...@lists.oasis-ope

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Michael S. Tsirkin
On Mon, Aug 08, 2016 at 06:27:15AM +, Zeng, Xin wrote: > On Thu, Friday, August 05, 2016 3:56 AM, Michael S. Tsirkin wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, August 05, 2016 3:56 AM > > To: Gonglei (Arei) > > Cc: Zeng, Xin; qe

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-09 Thread Cornelia Huck
On Mon, 8 Aug 2016 06:27:15 + "Zeng, Xin" wrote: > On Thu, Friday, August 05, 2016 3:56 AM, Michael S. Tsirkin wrote: > > -Original Message- > > From: Michael S. Tsirkin [mailto:m...@redhat.com] > > Sent: Friday, August 05, 2016 3:56 AM > > To: Gonglei (Arei) > > Cc: Zeng, Xin; qemu-d

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-07 Thread Zeng, Xin
On Thu, Friday, August 05, 2016 3:56 AM, Michael S. Tsirkin wrote: > -Original Message- > From: Michael S. Tsirkin [mailto:m...@redhat.com] > Sent: Friday, August 05, 2016 3:56 AM > To: Gonglei (Arei) > Cc: Zeng, Xin; qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org; > Huangpeng (Pete

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-04 Thread Michael S. Tsirkin
On Thu, Aug 04, 2016 at 11:24:26AM +, Gonglei (Arei) wrote: > > > +The first driver-read-only field, \field{version} specifies the virtio > > > crypto's > > > +version, which is reserved for back-compatibility in future.It's > > > currently > > > +defined for the version field: > > > + > > >

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-04 Thread Gonglei (Arei)
Hi Xin, Thanks for your feedback! Please see my embedded reply. Regards, -Gonglei > -Original Message- > From: Zeng, Xin [mailto:xin.z...@intel.com] > Sent: Thursday, August 04, 2016 3:48 PM > To: Gonglei (Arei); qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org > Cc: Huangpeng (Pe

Re: [Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-04 Thread Zeng, Xin
On Monday, August 01, 2016 5:20 PM, Gonglei Wrote: > -Original Message- > From: Gonglei [mailto:arei.gong...@huawei.com] > Sent: Monday, August 1, 2016 5:20 PM > To: qemu-devel@nongnu.org; virtio-...@lists.oasis-open.org > Cc: peter.huangp...@huawei.com; luoneng...@huawei.com; > m...@redhat

[Qemu-devel] [PATCH v6 1/2] virtio-crypto: Add virtio crypto device specification

2016-08-01 Thread Gonglei
The virtio crypto device is a virtual crypto device (ie. hardware crypto accelerator card). The virtio crypto device can provide five crypto services: CIPHER, MAC, HASH, AEAD, KDF, ASYM, PRIMITIVE. In this patch, CIPHER, MAC, HASH, AEAD services are introduced. Signed-off-by: Gonglei CC: Michael