Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-12 Thread Vladimir Sementsov-Ogievskiy
12.12.2017 19:32, Eric Blake wrote: On 12/11/2017 09:24 AM, Vladimir Sementsov-Ogievskiy wrote: On the other hand, '<< BDRV_SECTOR_BITS' only produces the same size output as the input; if the left side is 32 bits, it risks overflowing. But '* BDRV_SECTOR_SIZE' always produces a 64-bit value. 

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-12 Thread Eric Blake
On 12/11/2017 09:24 AM, Vladimir Sementsov-Ogievskiy wrote: >> On the other hand, '<< BDRV_SECTOR_BITS' only produces the same size >> output as the input; if the left side is 32 bits, it risks overflowing. >> But '* BDRV_SECTOR_SIZE' always produces a 64-bit value.  So I've >> learned (from past

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function block_sta

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-11 Thread Vladimir Sementsov-Ogievskiy
09.12.2017 19:39, Eric Blake wrote: On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: 07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based.  Update the parallels driver accordingly.  Note that the internal function block_sta

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-09 Thread Eric Blake
On 12/09/2017 06:31 AM, Vladimir Sementsov-Ogievskiy wrote: > 07.12.2017 23:30, Eric Blake wrote: >> We are gradually moving away from sector-based interfaces, towards >> byte-based.  Update the parallels driver accordingly.  Note that >> the internal function block_status() is still sector-based,

Re: [Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-09 Thread Vladimir Sementsov-Ogievskiy
07.12.2017 23:30, Eric Blake wrote: We are gradually moving away from sector-based interfaces, towards byte-based. Update the parallels driver accordingly. Note that the internal function block_status() is still sector-based, because it is still in use by other sector-based functions; but that'

[Qemu-devel] [PATCH v6 09/20] parallels: Switch to .bdrv_co_block_status()

2017-12-07 Thread Eric Blake
We are gradually moving away from sector-based interfaces, towards byte-based. Update the parallels driver accordingly. Note that the internal function block_status() is still sector-based, because it is still in use by other sector-based functions; but that's okay because request_alignment is 51