Re: [Qemu-devel] [PATCH v6 08/11] target-avr: adding instruction translation

2016-06-13 Thread Richard Henderson
On 06/13/2016 01:25 PM, Michael Rolnik wrote: what is the difference between tcg_gen_qemu_st16 and tcg_gen_qemu_st_tl st16 is a legacy interface; st_tl is newer and has an argument that is a mask of MO_* bits. MO_BEUW is a convenience name for MO_BE | MO_16. r~

Re: [Qemu-devel] [PATCH v6 08/11] target-avr: adding instruction translation

2016-06-13 Thread Michael Rolnik
what is the difference between tcg_gen_qemu_st16 and tcg_gen_qemu_st_tl On Mon, Jun 13, 2016 at 7:06 PM, Richard Henderson wrote: > On 06/12/2016 12:01 PM, Michael Rolnik wrote: > >> +void gen_push_ret(CPUAVRState *env, int ret) >> +{ >> +if (avr_feature(env, AVR_FEATURE_1_BYTE_PC)) { >> + >

Re: [Qemu-devel] [PATCH v6 08/11] target-avr: adding instruction translation

2016-06-13 Thread Richard Henderson
On 06/12/2016 12:01 PM, Michael Rolnik wrote: +void gen_push_ret(CPUAVRState *env, int ret) +{ +if (avr_feature(env, AVR_FEATURE_1_BYTE_PC)) { + +TCGv t0 = tcg_const_i32((ret & 0xff)); + +tcg_gen_qemu_st8(t0, cpu_sp, MMU_DATA_IDX); +tcg_gen_subi_tl(cpu_sp, cpu_sp,

[Qemu-devel] [PATCH v6 08/11] target-avr: adding instruction translation

2016-06-12 Thread Michael Rolnik
From: Michael Rolnik Signed-off-by: Michael Rolnik --- target-avr/translate-inst.c | 2624 +++ target-avr/translate.h | 119 ++ 2 files changed, 2743 insertions(+) create mode 100644 target-avr/translate-inst.c create mode 100644 target-avr/transl