Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-28 Thread Peter Xu
On Wed, Jun 28, 2017 at 04:13:57PM -0300, Eduardo Habkost wrote: > On Tue, Jun 27, 2017 at 12:10:15PM +0800, Peter Xu wrote: > > One less global variable, and it does only matter with migration. > > > > We keep the old "--only-migratable" option, but also now we support: > > > > -global migrati

Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-28 Thread Eduardo Habkost
On Tue, Jun 27, 2017 at 12:10:15PM +0800, Peter Xu wrote: > One less global variable, and it does only matter with migration. > > We keep the old "--only-migratable" option, but also now we support: > > -global migration.only-migratable=true > > Currently still keep the old interface. > > Hmm

Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-28 Thread Eduardo Habkost
On Wed, Jun 28, 2017 at 02:54:34PM +0800, Peter Xu wrote: > On Tue, Jun 27, 2017 at 10:36:44AM -0300, Eduardo Habkost wrote: > > On Tue, Jun 27, 2017 at 06:15:37AM -0500, Eric Blake wrote: > > > On 06/26/2017 11:10 PM, Peter Xu wrote: > > > > One less global variable, and it does only matter with m

Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-27 Thread Peter Xu
On Tue, Jun 27, 2017 at 10:36:44AM -0300, Eduardo Habkost wrote: > On Tue, Jun 27, 2017 at 06:15:37AM -0500, Eric Blake wrote: > > On 06/26/2017 11:10 PM, Peter Xu wrote: > > > One less global variable, and it does only matter with migration. > > > > > > We keep the old "--only-migratable" option,

Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-27 Thread Eduardo Habkost
On Tue, Jun 27, 2017 at 06:15:37AM -0500, Eric Blake wrote: > On 06/26/2017 11:10 PM, Peter Xu wrote: > > One less global variable, and it does only matter with migration. > > > > We keep the old "--only-migratable" option, but also now we support: > > > > -global migration.only-migratable=true

Re: [Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-27 Thread Eric Blake
On 06/26/2017 11:10 PM, Peter Xu wrote: > One less global variable, and it does only matter with migration. > > We keep the old "--only-migratable" option, but also now we support: > > -global migration.only-migratable=true Does command line introspection work to see that this new spelling is

[Qemu-devel] [PATCH v6 06/10] migration: move only_migratable to MigrationState

2017-06-26 Thread Peter Xu
One less global variable, and it does only matter with migration. We keep the old "--only-migratable" option, but also now we support: -global migration.only-migratable=true Currently still keep the old interface. Hmm, now vl.c has no way to access migrate_get_current(). Export a function for