Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-19 Thread Shannon Zhao
On 2015/5/19 20:09, Igor Mammedov wrote: >> > Also, enum values must all be formatted like this: >> >UPPER_CASE > may be better not, for consistency with the rest of enums in this header. > Will add another patch to fix the enums of this header firstly. -- Shannon

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-19 Thread Igor Mammedov
On Mon, 18 May 2015 12:34:04 +0200 "Michael S. Tsirkin" wrote: > On Mon, May 18, 2015 at 12:00:09PM +0800, Shannon Zhao wrote: > > On 2015/5/15 20:45, Igor Mammedov wrote: > > > On Thu, 7 May 2015 17:29:07 +0800 > > > Shannon Zhao wrote: > > > > > >> From: Shannon Zhao > > >> > > >> Add aml_in

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-19 Thread Igor Mammedov
On Mon, 18 May 2015 12:33:25 +0200 "Michael S. Tsirkin" wrote: > On Mon, May 18, 2015 at 12:05:49PM +0800, Shannon Zhao wrote: > > On 2015/5/15 20:14, Igor Mammedov wrote: > > > On Thu, 7 May 2015 16:51:31 +0100 > > > Peter Maydell wrote: > > > > > >> > On 7 May 2015 at 10:29, Shannon Zhao wro

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-18 Thread Michael S. Tsirkin
On Mon, May 18, 2015 at 12:00:09PM +0800, Shannon Zhao wrote: > On 2015/5/15 20:45, Igor Mammedov wrote: > > On Thu, 7 May 2015 17:29:07 +0800 > > Shannon Zhao wrote: > > > >> From: Shannon Zhao > >> > >> Add aml_interrupt() for describing device interrupt in resource template. > >> These can be

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-18 Thread Michael S. Tsirkin
On Mon, May 18, 2015 at 12:05:49PM +0800, Shannon Zhao wrote: > On 2015/5/15 20:14, Igor Mammedov wrote: > > On Thu, 7 May 2015 16:51:31 +0100 > > Peter Maydell wrote: > > > >> > On 7 May 2015 at 10:29, Shannon Zhao wrote: > >>> > > From: Shannon Zhao > >>> > > > >>> > > Add aml_interrupt() for

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-17 Thread Shannon Zhao
On 2015/5/15 20:14, Igor Mammedov wrote: > On Thu, 7 May 2015 16:51:31 +0100 > Peter Maydell wrote: > >> > On 7 May 2015 at 10:29, Shannon Zhao wrote: >>> > > From: Shannon Zhao >>> > > >>> > > Add aml_interrupt() for describing device interrupt in resource >>> > > template. >>> > > These can

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-17 Thread Shannon Zhao
On 2015/5/15 20:45, Igor Mammedov wrote: > On Thu, 7 May 2015 17:29:07 +0800 > Shannon Zhao wrote: > >> From: Shannon Zhao >> >> Add aml_interrupt() for describing device interrupt in resource template. >> These can be used to generating DSDT table for ACPI on ARM. >> >> Signed-off-by: Shannon Z

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 17:29:07 +0800 Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_interrupt() for describing device interrupt in resource template. > These can be used to generating DSDT table for ACPI on ARM. > > Signed-off-by: Shannon Zhao > Signed-off-by: Shannon Zhao > --- > hw/acp

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-15 Thread Igor Mammedov
On Thu, 7 May 2015 16:51:31 +0100 Peter Maydell wrote: > On 7 May 2015 at 10:29, Shannon Zhao wrote: > > From: Shannon Zhao > > > > Add aml_interrupt() for describing device interrupt in resource template. > > These can be used to generating DSDT table for ACPI on ARM. > > > +/* Interrupt

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-07 Thread Shannon Zhao
On 2015/5/7 23:51, Peter Maydell wrote: > On 7 May 2015 at 10:29, Shannon Zhao wrote: >> > From: Shannon Zhao >> > >> > Add aml_interrupt() for describing device interrupt in resource template. >> > These can be used to generating DSDT table for ACPI on ARM. >> > +/* Interrupt Number */ >> >

Re: [Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-07 Thread Peter Maydell
On 7 May 2015 at 10:29, Shannon Zhao wrote: > From: Shannon Zhao > > Add aml_interrupt() for describing device interrupt in resource template. > These can be used to generating DSDT table for ACPI on ARM. > +/* Interrupt Number */ > +build_append_byte(var->buf, extract32(irq, 0, 8)); /*

[Qemu-devel] [PATCH v6 05/22] hw/acpi/aml-build: Add aml_interrupt() term

2015-05-07 Thread Shannon Zhao
From: Shannon Zhao Add aml_interrupt() for describing device interrupt in resource template. These can be used to generating DSDT table for ACPI on ARM. Signed-off-by: Shannon Zhao Signed-off-by: Shannon Zhao --- hw/acpi/aml-build.c | 28 + include/hw/acpi/aml-