Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-10 Thread Kevin Wolf
Am 10.09.2019 um 14:59 hat Max Reitz geschrieben: > On 10.09.19 14:48, Kevin Wolf wrote: > > Am 10.09.2019 um 13:36 hat Max Reitz geschrieben: > >> On 10.09.19 12:47, Kevin Wolf wrote: > >>> Am 10.09.2019 um 11:14 hat Max Reitz geschrieben: > Maybe we should stop declaring Quorum a filter and

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-10 Thread Max Reitz
On 10.09.19 14:48, Kevin Wolf wrote: > Am 10.09.2019 um 13:36 hat Max Reitz geschrieben: >> On 10.09.19 12:47, Kevin Wolf wrote: >>> Am 10.09.2019 um 11:14 hat Max Reitz geschrieben: Maybe we should stop declaring Quorum a filter and then rename the bdrv_recurse_is_first_non_filter() to,

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-10 Thread Kevin Wolf
Am 10.09.2019 um 13:36 hat Max Reitz geschrieben: > On 10.09.19 12:47, Kevin Wolf wrote: > > Am 10.09.2019 um 11:14 hat Max Reitz geschrieben: > >> Maybe we should stop declaring Quorum a filter and then rename the > >> bdrv_recurse_is_first_non_filter() to, I don’t know, > >> bdrv_recurse_can_be_r

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-10 Thread Max Reitz
On 10.09.19 12:47, Kevin Wolf wrote: > Am 10.09.2019 um 11:14 hat Max Reitz geschrieben: >> On 09.09.19 18:13, Kevin Wolf wrote: >>> Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: On 09.09.19 11:36, Kevin Wolf wrote: > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: >> On 04.09.19

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-10 Thread Kevin Wolf
Am 10.09.2019 um 11:14 hat Max Reitz geschrieben: > On 09.09.19 18:13, Kevin Wolf wrote: > > Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: > >> On 09.09.19 11:36, Kevin Wolf wrote: > >>> Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > On 04.09.19 18:16, Kevin Wolf wrote: > > Am 09.

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-10 Thread Max Reitz
On 09.09.19 18:13, Kevin Wolf wrote: > Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: >> On 09.09.19 11:36, Kevin Wolf wrote: >>> Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: On 04.09.19 18:16, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> There are B

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 16:04 hat Max Reitz geschrieben: > On 09.09.19 11:36, Kevin Wolf wrote: > > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > >> On 04.09.19 18:16, Kevin Wolf wrote: > >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > There are BDS children that the general block layer

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Max Reitz
On 09.09.19 11:36, Kevin Wolf wrote: > Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: >> On 04.09.19 18:16, Kevin Wolf wrote: >>> Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Sin

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Kevin Wolf
Am 09.09.2019 um 09:56 hat Max Reitz geschrieben: > On 04.09.19 18:16, Kevin Wolf wrote: > > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > >> There are BDS children that the general block layer code can access, > >> namely bs->file and bs->backing. Since the introduction of filters and > >>

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-09 Thread Max Reitz
On 04.09.19 18:16, Kevin Wolf wrote: > Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: >> There are BDS children that the general block layer code can access, >> namely bs->file and bs->backing. Since the introduction of filters and >> external data files, their meaning is not quite clear. bs->

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-09-04 Thread Kevin Wolf
Am 09.08.2019 um 18:13 hat Max Reitz geschrieben: > There are BDS children that the general block layer code can access, > namely bs->file and bs->backing. Since the introduction of filters and > external data files, their meaning is not quite clear. bs->backing can > be a COW source, or it can b

Re: [Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-08-09 Thread Eric Blake
On 8/9/19 11:13 AM, Max Reitz wrote: > There are BDS children that the general block layer code can access, > namely bs->file and bs->backing. Since the introduction of filters and > external data files, their meaning is not quite clear. bs->backing can > be a COW source, or it can be an R/W-filt

[Qemu-devel] [PATCH v6 04/42] block: Add child access functions

2019-08-09 Thread Max Reitz
There are BDS children that the general block layer code can access, namely bs->file and bs->backing. Since the introduction of filters and external data files, their meaning is not quite clear. bs->backing can be a COW source, or it can be an R/W-filtered child; bs->file can be an R/W-filtered c