Re: [Qemu-devel] [PATCH v6 02/50] tcg: Propagate args to op->args in optimizer

2017-10-17 Thread Richard Henderson
On 10/17/2017 01:28 PM, Emilio G. Cota wrote: >> -TCGArg * const args = op->args; > > Reviewed-by: Emilio G. Cota > > Just for my own education: why doesn't gcc generate the same code when > leaving 'args' as above? I thought we could simplify the diff without > any side effects, but it

Re: [Qemu-devel] [PATCH v6 02/50] tcg: Propagate args to op->args in optimizer

2017-10-17 Thread Emilio G. Cota
On Mon, Oct 16, 2017 at 10:25:21 -0700, Richard Henderson wrote: > From: Richard Henderson > > Reviewed-by: Alex Bennée > Signed-off-by: Richard Henderson > --- > tcg/optimize.c | 430 > ++--- (snip) > @@ -559,7 +557,7 @@ static bool swap_com

[Qemu-devel] [PATCH v6 02/50] tcg: Propagate args to op->args in optimizer

2017-10-16 Thread Richard Henderson
From: Richard Henderson Reviewed-by: Alex Bennée Signed-off-by: Richard Henderson --- tcg/optimize.c | 430 ++--- 1 file changed, 227 insertions(+), 203 deletions(-) diff --git a/tcg/optimize.c b/tcg/optimize.c index 002aad6bf4..1a1c6fb90c 1