On Thu, May 07, 2015 at 09:55:45AM +0200, Michael Mueller wrote:
> On Wed, 6 May 2015 08:41:50 -0300
> Eduardo Habkost wrote:
[...]
> > > > > diff --git a/qom/cpu.c b/qom/cpu.c
> > > > > index 108bfa2..457afc7 100644
> > > > > --- a/qom/cpu.c
> > > > > +++ b/qom/cpu.c
> > > > > @@ -67,6 +67,20 @@
On Wed, 6 May 2015 08:41:50 -0300
Eduardo Habkost wrote:
> On Wed, May 06, 2015 at 11:59:38AM +0200, Michael Mueller wrote:
> > On Tue, 5 May 2015 10:26:02 -0300
> > Eduardo Habkost wrote:
> >
> > > On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote:
> > > > The patch defines ids p
On Wed, May 06, 2015 at 11:59:38AM +0200, Michael Mueller wrote:
> On Tue, 5 May 2015 10:26:02 -0300
> Eduardo Habkost wrote:
>
> > On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote:
> > > The patch defines ids per accelerator and adds the accel_id and
> > > the model_name to the CP
On Tue, 5 May 2015 10:26:02 -0300
Eduardo Habkost wrote:
> On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote:
> > The patch defines ids per accelerator and adds the accel_id and
> > the model_name to the CPUState. The accel_id is initialized by
> > common code, the model name needs
On Tue, 5 May 2015 11:46:04 -0300
Eduardo Habkost wrote:
> On Tue, May 05, 2015 at 08:36:45AM -0600, Eric Blake wrote:
> > On 05/05/2015 07:26 AM, Eduardo Habkost wrote:
> > >> +{ 'enum': 'AccelId',
> > >> + 'data': ['qtest', 'tcg', 'kvm', 'xen'] }
> > >> +
> > >
> > > Not sure if it is better
On Tue, May 05, 2015 at 08:36:45AM -0600, Eric Blake wrote:
> On 05/05/2015 07:26 AM, Eduardo Habkost wrote:
> >> +{ 'enum': 'AccelId',
> >> + 'data': ['qtest', 'tcg', 'kvm', 'xen'] }
> >> +
> >
> > Not sure if it is better to have an enum or simply a string here.
>
> enum is almost always bette
On 05/05/2015 07:26 AM, Eduardo Habkost wrote:
> On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote:
>> The patch defines ids per accelerator and adds the accel_id and
>> the model_name to the CPUState. The accel_id is initialized by
>> common code, the model name needs to be initializ
On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote:
> The patch defines ids per accelerator and adds the accel_id and
> the model_name to the CPUState. The accel_id is initialized by
> common code, the model name needs to be initialized by target
> specific code.
>
> Signed-off-by: Mi
The patch defines ids per accelerator and adds the accel_id and
the model_name to the CPUState. The accel_id is initialized by
common code, the model name needs to be initialized by target
specific code.
Signed-off-by: Michael Mueller
Acked-by: Christian Borntraeger
---
include/qom/cpu.h | 5 +