Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Edgar E. Iglesias
On Thu, Sep 25, 2014 at 07:15:29PM +0100, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h| 19 ++- > > target-arm/helper.c | 35

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Greg Bellows
Thanks for the clarification. On 25 September 2014 14:53, Peter Maydell wrote: > On 25 September 2014 20:49, Greg Bellows wrote: > > Is it necessary to make SCR 64-bit if it is 32-bit on both v7 and v8? > > See previous round of reviews -- all AArch64 system registers > are 64 bits ("32 bit" in

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Peter Maydell
On 25 September 2014 20:49, Greg Bellows wrote: > Is it necessary to make SCR 64-bit if it is 32-bit on both v7 and v8? See previous round of reviews -- all AArch64 system registers are 64 bits ("32 bit" in the ARM ARM is just a shorthand for "64 bit with the top half RES0"; there is no "read 32

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Greg Bellows
Is it necessary to make SCR 64-bit if it is 32-bit on both v7 and v8? On 25 September 2014 13:15, Peter Maydell wrote: > On 13 September 2014 05:29, Edgar E. Iglesias > wrote: > > From: "Edgar E. Iglesias" > > > > Signed-off-by: Edgar E. Iglesias > > --- > > target-arm/cpu.h| 19

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-25 Thread Peter Maydell
On 13 September 2014 05:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 19 ++- > target-arm/helper.c | 35 +-- > 2 files changed, 51 insertions(+), 3 deletions(-) > > dif

Re: [Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-17 Thread Greg Bellows
Reviewed-by: Greg Bellows On 12 September 2014 21:29, Edgar E. Iglesias wrote: > From: "Edgar E. Iglesias" > > Signed-off-by: Edgar E. Iglesias > --- > target-arm/cpu.h| 19 ++- > target-arm/helper.c | 35 +-- > 2 files changed, 51 insertio

[Qemu-devel] [PATCH v6 02/10] target-arm: Add SCR_EL3

2014-09-12 Thread Edgar E. Iglesias
From: "Edgar E. Iglesias" Signed-off-by: Edgar E. Iglesias --- target-arm/cpu.h| 19 ++- target-arm/helper.c | 35 +-- 2 files changed, 51 insertions(+), 3 deletions(-) diff --git a/target-arm/cpu.h b/target-arm/cpu.h index 36507f9..c69d471 1