Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

2018-08-27 Thread Peter Xu
On Mon, Aug 27, 2018 at 01:29:29PM +0200, Markus Armbruster wrote: > > @@ -4624,15 +4624,10 @@ static void monitor_qmp_setup_handlers_bh(void > > *opaque) > > Monitor *mon = opaque; > > GMainContext *context; > > > > -if (mon->use_io_thread) { > > -/* Use @mon_iothread cont

Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

2018-08-27 Thread Markus Armbruster
Peter Xu writes: > When we reach monitor_qmp_setup_handlers_bh() we must be using the > IOThread then, so no need to check against it any more. Instead, we > assert. > > Reviewed-by: Markus Armbruster > Signed-off-by: Peter Xu > --- > monitor.c | 13 - > 1 file changed, 4 insertio

Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

2018-08-21 Thread Peter Xu
On Tue, Aug 21, 2018 at 08:13:59PM +0200, Marc-André Lureau wrote: > Hi > > On Wed, Aug 15, 2018 at 3:37 PM, Peter Xu wrote: > > When we reach monitor_qmp_setup_handlers_bh() we must be using the > > IOThread then, so no need to check against it any more. Instead, we > > assert. > > > > Reviewed

Re: [Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

2018-08-21 Thread Marc-André Lureau
Hi On Wed, Aug 15, 2018 at 3:37 PM, Peter Xu wrote: > When we reach monitor_qmp_setup_handlers_bh() we must be using the > IOThread then, so no need to check against it any more. Instead, we > assert. > > Reviewed-by: Markus Armbruster > Signed-off-by: Peter Xu That's a clear simplification t

[Qemu-devel] [PATCH v6 01/13] monitor: simplify monitor_qmp_setup_handlers_bh

2018-08-15 Thread Peter Xu
When we reach monitor_qmp_setup_handlers_bh() we must be using the IOThread then, so no need to check against it any more. Instead, we assert. Reviewed-by: Markus Armbruster Signed-off-by: Peter Xu --- monitor.c | 13 - 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/