Re: [Qemu-devel] [PATCH v6 01/11] hw/rdma: Switch to generic error reporting way

2019-03-14 Thread Marcel Apfelbaum
On 3/12/19 4:23 PM, Yuval Shaia wrote: On Tue, Mar 12, 2019 at 02:23:22PM +0200, Kamal Heib wrote: On 3/11/19 12:29 PM, Yuval Shaia wrote: Utilize error_report for all pr_err calls and some pr_dbg that are considered as errors. For the remaining pr_dbg calls, the important ones were replace

Re: [Qemu-devel] [PATCH v6 01/11] hw/rdma: Switch to generic error reporting way

2019-03-12 Thread Yuval Shaia
On Tue, Mar 12, 2019 at 02:23:22PM +0200, Kamal Heib wrote: > > > On 3/11/19 12:29 PM, Yuval Shaia wrote: > > Utilize error_report for all pr_err calls and some pr_dbg that are > > considered as errors. > > For the remaining pr_dbg calls, the important ones were replaced by > > trace points while

Re: [Qemu-devel] [PATCH v6 01/11] hw/rdma: Switch to generic error reporting way

2019-03-12 Thread Kamal Heib
On 3/11/19 12:29 PM, Yuval Shaia wrote: > Utilize error_report for all pr_err calls and some pr_dbg that are > considered as errors. > For the remaining pr_dbg calls, the important ones were replaced by > trace points while other deleted. > I suggest updating the commit message to include that

[Qemu-devel] [PATCH v6 01/11] hw/rdma: Switch to generic error reporting way

2019-03-11 Thread Yuval Shaia
Utilize error_report for all pr_err calls and some pr_dbg that are considered as errors. For the remaining pr_dbg calls, the important ones were replaced by trace points while other deleted. Signed-off-by: Yuval Shaia Reviewed-by: Marcel Apfelbaum --- hw/rdma/rdma_backend.c| 354 +++