Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-30 Thread Eduardo Habkost
On Fri, Aug 18, 2017 at 04:26:03PM +0200, Lukáš Doktor wrote: > Hello guys, > > I'm reading the available python modules to exercise qemu and while reading > them > I fixed some issues that caught my attention. It usually starts with a simple > pylint/docstring fixes and slowly graduates to more

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-24 Thread Philippe Mathieu-Daudé
On 08/24/2017 09:15 AM, Stefan Hajnoczi wrote: On Tue, Aug 22, 2017 at 04:07:09PM -0300, Eduardo Habkost wrote: (CCing Cleber and Stefan) On Tue, Aug 22, 2017 at 07:19:45AM -0300, Philippe Mathieu-Daudé wrote: [...] Can we predict how the python scripts will evolve? Only fast-testing? I gue

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-24 Thread Stefan Hajnoczi
On Tue, Aug 22, 2017 at 04:07:09PM -0300, Eduardo Habkost wrote: > (CCing Cleber and Stefan) > > On Tue, Aug 22, 2017 at 07:19:45AM -0300, Philippe Mathieu-Daudé wrote: > [...] > > Can we predict how the python scripts will evolve? Only fast-testing? > > > > I guess it depends on how you define

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Eduardo Habkost
(CCing Cleber and Stefan) On Tue, Aug 22, 2017 at 07:19:45AM -0300, Philippe Mathieu-Daudé wrote: [...] > Can we predict how the python scripts will evolve? Only fast-testing? > I guess it depends on how you define "fast". Does "fast-testing" include a full device-crash-test run (that could tak

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Eduardo Habkost
On Tue, Aug 22, 2017 at 09:24:16AM +0200, Markus Armbruster wrote: > John Snow writes: > > > On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > >> Hello guys, > >> > >> I'm reading the available python modules to exercise qemu and while > >> reading them > >> I fixed some issues that caught my atten

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread John Snow
On 08/22/2017 03:24 AM, Markus Armbruster wrote: > John Snow writes: > >> On 08/18/2017 10:26 AM, Lukáš Doktor wrote: >>> Hello guys, >>> >>> I'm reading the available python modules to exercise qemu and while reading >>> them >>> I fixed some issues that caught my attention. It usually starts

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Paolo Bonzini
On 22/08/2017 09:24, Markus Armbruster wrote: > John Snow writes: > >> On 08/18/2017 10:26 AM, Lukáš Doktor wrote: >>> Hello guys, >>> >>> I'm reading the available python modules to exercise qemu and while reading >>> them >>> I fixed some issues that caught my attention. It usually starts with

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Philippe Mathieu-Daudé
On 08/22/2017 04:24 AM, Markus Armbruster wrote: John Snow writes: [...] Looks like all ten patches have an R-B despite changes; but it looks like nothing particularly major was changed anyway. Does this fall under Markus's jurisdiction? (Well, except for qtest.py which seemingly has double

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-22 Thread Markus Armbruster
John Snow writes: > On 08/18/2017 10:26 AM, Lukáš Doktor wrote: >> Hello guys, >> >> I'm reading the available python modules to exercise qemu and while reading >> them >> I fixed some issues that caught my attention. It usually starts with a simple >> pylint/docstring fixes and slowly graduate

Re: [Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-21 Thread John Snow
On 08/18/2017 10:26 AM, Lukáš Doktor wrote: > Hello guys, > > I'm reading the available python modules to exercise qemu and while reading > them > I fixed some issues that caught my attention. It usually starts with a simple > pylint/docstring fixes and slowly graduates to more controversial on

[Qemu-devel] [PATCH v6 00/10] qemu.py: Pylint/style fixes

2017-08-18 Thread Lukáš Doktor
Hello guys, I'm reading the available python modules to exercise qemu and while reading them I fixed some issues that caught my attention. It usually starts with a simple pylint/docstring fixes and slowly graduates to more controversial ones so I'm open to suggestion to remove some of them. Kind