Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Jeff King
On Mon, Sep 23, 2019 at 01:19:18PM +0200, Christian Schoenebeck wrote: > > if (cmit_fmt_is_mail(pp->fmt)) { > > - if (pp->from_ident && ident_cmp(pp->from_ident, &ident)) { > > + if (pp->always_use_in_body_from || > > + (pp->from_ident && ident_cmp(pp->from_id

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Christian Schoenebeck via
On Donnerstag, 5. September 2019 14:59:31 CEST Greg Kurz wrote: > On Thu, 05 Sep 2019 14:25:13 +0200 > > Christian Schoenebeck wrote: > > On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > > > Well, mailman is handling this correctly. It replaces the "From:" > > > > >

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-23 Thread Christian Schoenebeck via
On Montag, 9. September 2019 16:25:12 CEST Jeff King wrote: > On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote: > > > But as you can already read from the manual, the overall behaviour of > > > git > > > regarding a separate "From:" line in the email body was intended solely > > > for > >

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Junio C Hamano
Eric Blake writes: > How hard would it be to improve 'git format-patch'/'git send-email' to > have an option to ALWAYS output a From: line in the body, even when the > sender is the author, for the case of a mailing list that munges the > mail headers due to DMARC/DKIM reasons? I'd say that it s

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Jeff King
On Mon, Sep 09, 2019 at 09:05:45AM -0500, Eric Blake wrote: > > But as you can already read from the manual, the overall behaviour of git > > regarding a separate "From:" line in the email body was intended solely for > > the use case sender != author. So in practice (at least in my git version)

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-09 Thread Eric Blake
[adding git list] On 9/5/19 7:25 AM, Christian Schoenebeck wrote: > How are you sending patches ? With git send-email ? If so, maybe you > can > pass something like --from='"Christian Schoenebeck" > '. Since this is a different string, git will > assume you're sending someone

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-05 Thread Greg Kurz
On Thu, 05 Sep 2019 14:25:13 +0200 Christian Schoenebeck wrote: > On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > > Well, mailman is handling this correctly. It replaces the "From:" field > > > > with a placeholder and instead adds my actual email address as > > >

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-05 Thread Christian Schoenebeck via Qemu-devel
On Mittwoch, 4. September 2019 15:02:30 CEST Christian Schoenebeck wrote: > > > Well, mailman is handling this correctly. It replaces the "From:" field > > > with a placeholder and instead adds my actual email address as > > > "Reply-To:" field. That's the common way to handle this on mailing > > >

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-04 Thread Christian Schoenebeck via Qemu-devel
On Dienstag, 3. September 2019 21:38:15 CEST Eric Blake wrote: > On 9/2/19 5:29 PM, Christian Schoenebeck via Qemu-devel wrote: > > === OUTPUT BEGIN === > > 1/4 Checking commit bb69de63f788 (9p: Treat multiple devices on one > > export > > as an error) ERROR: Author email address is

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-03 Thread Eric Blake
On 9/2/19 5:29 PM, Christian Schoenebeck via Qemu-devel wrote: > === OUTPUT BEGIN === > 1/4 Checking commit bb69de63f788 (9p: Treat multiple devices on one > export > as an error) ERROR: Author email address is mangled by the mailing > list > #2: > Author: Christian Sch

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-02 Thread Christian Schoenebeck via Qemu-devel
On Montag, 2. September 2019 17:34:32 CEST Greg Kurz wrote: > On Sun, 01 Sep 2019 21:28:45 +0200 > > Christian Schoenebeck wrote: > > On Donnerstag, 29. August 2019 19:02:34 CEST Greg Kurz wrote: > > > On Thu, 22 Aug 2019 15:18:54 -0700 (PDT) > > > > > > no-re...@patchew.org wrote: > > > > Patch

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-02 Thread Greg Kurz
On Sun, 01 Sep 2019 21:28:45 +0200 Christian Schoenebeck wrote: > On Donnerstag, 29. August 2019 19:02:34 CEST Greg Kurz wrote: > > On Thu, 22 Aug 2019 15:18:54 -0700 (PDT) > > > > no-re...@patchew.org wrote: > > > Patchew URL: > > > https://patchew.org/QEMU/cover.1566503584.git.qemu_...@crudeby

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-09-01 Thread Christian Schoenebeck via Qemu-devel
On Donnerstag, 29. August 2019 19:02:34 CEST Greg Kurz wrote: > On Thu, 22 Aug 2019 15:18:54 -0700 (PDT) > > no-re...@patchew.org wrote: > > Patchew URL: > > https://patchew.org/QEMU/cover.1566503584.git.qemu_...@crudebyte.com/ > > > > > > > > Hi, > > > > This series seems to have some coding

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-08-29 Thread Greg Kurz
ormation: > > Type: series > Subject: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions > Message-id: cover.1566503584.git.qemu_...@crudebyte.com > > === TEST SCRIPT BEGIN === > #!/bin/bash > git rev-parse base > /dev/null || exit 0 > git config --local diff.renameli

Re: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-08-22 Thread no-reply
Patchew URL: https://patchew.org/QEMU/cover.1566503584.git.qemu_...@crudebyte.com/ Hi, This series seems to have some coding style problems. See output below for more information: Type: series Subject: [Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions Message-id: cover.1566503584

[Qemu-devel] [PATCH v6 0/4] 9p: Fix file ID collisions

2019-08-22 Thread Christian Schoenebeck via Qemu-devel
This is v6 of a proposed patch set for fixing file ID collisions with 9pfs. v5->v6: * Rebased to https://github.com/gkurz/qemu/commits/9p-next (SHA1 177fd3b6a8). * Replaced previous boolean option 'remap_inodes' by tertiary option 'multidevs=remap|forbid|warn', where 'warn' is the ne