Re: [Qemu-devel] [PATCH v6] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-17 Thread P J P
+-- On Mon, 17 Oct 2016, Peter Maydell wrote --+ | > +inc = QEMU_ALIGN_DOWN(inc, gtb->inc); | | Isn't this pair of lines equivalent to | uint64_t inc = QEMU_ALIGN_UP(update.new - gtb->compare, gtb->inc); | ? Yes, sent v7. Thank you. -- Prasad J Pandit / Red Hat Product Secur

Re: [Qemu-devel] [PATCH v6] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-17 Thread Peter Maydell
On 14 October 2016 at 04:43, P J P wrote: > From: Prasad J Pandit > > ARM A9MP processor has a peripheral timer with an auto-increment > register, which holds an increment step value. A user could set > this value to zero. When auto-increment control bit is enabled, > it leads to an infinite loop

[Qemu-devel] [PATCH v6] timer: a9gtimer: remove loop to auto-increment comparator

2016-10-13 Thread P J P
From: Prasad J Pandit ARM A9MP processor has a peripheral timer with an auto-increment register, which holds an increment step value. A user could set this value to zero. When auto-increment control bit is enabled, it leads to an infinite loop in 'a9_gtimer_update' while updating comparator value