Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Pino Toscano
On Thursday, 13 June 2019 21:41:58 CEST Stefan Weil wrote: > On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > [...] > > Note, libssh is not available on MinGW. > > Nor is it available for Mingw64: > > https://cygwin.com/cgi-bin2/package-grep.c

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Stefan Weil
On 14.06.19 12:13, Philippe Mathieu-Daudé wrote: > I agree with Kevin. The only user of the 'ssh' block driver that I am > aware of is the virt-v2v tool: > > http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt > > Stefan, do you think someone would use it

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 2:29 PM, Stefan Weil wrote: > On 14.06.19 12:13, Philippe Mathieu-Daudé wrote: >> I agree with Kevin. The only user of the 'ssh' block driver that I am >> aware of is the virt-v2v tool: >> >> http://libguestfs.org/virt-v2v.1.html#convert-from-esxi-hypervisor-over-ssh-to-local-libvirt >>

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Philippe Mathieu-Daudé
On 6/14/19 11:42 AM, Kevin Wolf wrote: > Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben: >> On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: >>> Cc'ing Alex (Docker, Travis) and Stefan (MinGW) >> [...] >>> Note, libssh is not available on MinGW. >> >> Nor is it available for Mingw64: Yes, by "

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-14 Thread Kevin Wolf
Am 13.06.2019 um 21:41 hat Stefan Weil geschrieben: > On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > [...] > > Note, libssh is not available on MinGW. > > Nor is it available for Mingw64: > > https://cygwin.com/cgi-bin2/package-grep.cgi?grep

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-13 Thread Stefan Weil
On 12.06.19 15:27, Philippe Mathieu-Daudé wrote: > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) [...] > Note, libssh is not available on MinGW. Nor is it available for Mingw64: https://cygwin.com/cgi-bin2/package-grep.cgi?grep=mingw64-x86_64-libssh&arch=x86_64 That makes building for Windows

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-13 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Cc'ing Alex (Docker, Travis) and Stefan (MinGW) > > On 6/5/19 11:36 PM, Pino Toscano wrote: >> Rewrite the implementation of the ssh block driver to use libssh instead >> of libssh2. The libssh library has various advantages over libssh2: >> - easier API for au

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-12 Thread Philippe Mathieu-Daudé
Cc'ing Alex (Docker, Travis) and Stefan (MinGW) On 6/5/19 11:36 PM, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-age

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-07 Thread Daniel P . Berrangé
On Thu, Jun 06, 2019 at 07:51:15PM +0200, Pino Toscano wrote: > On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote: > > On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: > > > Rewrite the implementation of the ssh block driver to use libssh instead > > > of libssh2. The li

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-07 Thread Daniel P . Berrangé
On Fri, Jun 07, 2019 at 12:14:37PM +0200, Philippe Mathieu-Daudé wrote: > On 6/7/19 12:08 PM, Daniel P. Berrangé wrote: > > On Thu, Jun 06, 2019 at 07:51:15PM +0200, Pino Toscano wrote: > >> On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote: > >>> On Wed, Jun 05, 2019 at 11:36:54PM +0

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-07 Thread Philippe Mathieu-Daudé
On 6/7/19 12:08 PM, Daniel P. Berrangé wrote: > On Thu, Jun 06, 2019 at 07:51:15PM +0200, Pino Toscano wrote: >> On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote: >>> On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: Rewrite the implementation of the ssh block driver

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-06 Thread Pino Toscano
On Thursday, 6 June 2019 13:12:32 CEST Daniel P. Berrangé wrote: > On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: > > Rewrite the implementation of the ssh block driver to use libssh instead > > of libssh2. The libssh library has various advantages over libssh2: > > - easier API for

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-06 Thread Daniel P . Berrangé
On Wed, Jun 05, 2019 at 11:36:54PM +0200, Pino Toscano wrote: > Rewrite the implementation of the ssh block driver to use libssh instead > of libssh2. The libssh library has various advantages over libssh2: > - easier API for authentication (for example for using ssh-agent) > - easier API for know

Re: [Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-05 Thread no-reply
Patchew URL: https://patchew.org/QEMU/20190605213654.9785-1-ptosc...@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190605213654.9785-1-ptosc...@redhat.com Type: series Subject: [Qemu-devel] [PATCH v6] ssh: switch

[Qemu-devel] [PATCH v6] ssh: switch from libssh2 to libssh

2019-06-05 Thread Pino Toscano
Rewrite the implementation of the ssh block driver to use libssh instead of libssh2. The libssh library has various advantages over libssh2: - easier API for authentication (for example for using ssh-agent) - easier API for known_hosts handling - supports newer types of keys in known_hosts Use AP