Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2012-01-08 Thread Dong Xu Wang
Okay, I will consider your suggestion in version 7. Thank you Marcelo and Stefan, :). On Fri, Jan 6, 2012 at 16:22, Stefan Hajnoczi wrote: > On Thu, Jan 05, 2012 at 01:46:08PM -0200, Marcelo Tosatti wrote: > > On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: > > > From: Dong Xu Wang

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2012-01-06 Thread Stefan Hajnoczi
On Thu, Jan 05, 2012 at 01:46:08PM -0200, Marcelo Tosatti wrote: > On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: > > From: Dong Xu Wang > > > > Introduce a new file format: add-cow. The usage can be found in add-cow.txt > > of > > this patch. > > > > CC: Kevin Wolf > > CC: Stef

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2012-01-05 Thread Marcelo Tosatti
On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: > From: Dong Xu Wang > > Introduce a new file format: add-cow. The usage can be found in add-cow.txt of > this patch. > > CC: Kevin Wolf > CC: Stefan Hajnoczi > Signed-off-by: Dong Xu Wang > --- > After applying this patch, qemu mi

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2012-01-01 Thread Stefan Hajnoczi
On Sat, Dec 31, 2011 at 9:17 AM, Dong Xu Wang wrote: > On Fri, Dec 30, 2011 at 22:09, Stefan Hajnoczi wrote: >> On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: >> > +    ret = bdrv_file_open(&backing_bs, bs->backing_file, 0); >> > +    if (ret < 0) { >> > +        return ret; >> > +

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2011-12-31 Thread Dong Xu Wang
On Fri, Dec 30, 2011 at 22:09, Stefan Hajnoczi wrote: > On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: > > Some comments on everything but the I/O path, which I haven't reviewed > yet: > > > diff --git a/block/add-cow.c b/block/add-cow.c > > new file mode 100644 > > index 000..

Re: [Qemu-devel] [PATCH v6] block:add-cow file format

2011-12-30 Thread Stefan Hajnoczi
On Thu, Dec 29, 2011 at 05:36:59PM +0800, Dong Xu Wang wrote: Some comments on everything but the I/O path, which I haven't reviewed yet: > diff --git a/block/add-cow.c b/block/add-cow.c > new file mode 100644 > index 000..95af5b7 > --- /dev/null > +++ b/block/add-cow.c > @@ -0,0 +1,429 @@ M

[Qemu-devel] [PATCH v6] block:add-cow file format

2011-12-29 Thread Dong Xu Wang
From: Dong Xu Wang Introduce a new file format: add-cow. The usage can be found in add-cow.txt of this patch. CC: Kevin Wolf CC: Stefan Hajnoczi Signed-off-by: Dong Xu Wang --- After applying this patch, qemu might can not compile, need apply this patch first: http://lists.gnu.org/archive/ht