On 10/18/2017 06:34 AM, Daniel P. Berrange wrote:
> Thus I think we really ought to deal with capstone in the same
> way as dtc. We could make the check a little more advanced so that
> it checks for the particular capstone feature QEMU wants. That way
> if someone does have an outdated capstone we
On Tue, Oct 17, 2017 at 08:37:42AM -0700, Richard Henderson wrote:
> Do not require the submodule, but use it if present (in preference
> even to a system copy). This will allow us to easily use capstone
> in older systems for which a package is not available, and also
> easily track bug fixes fro
On 10/18/2017 12:48 AM, Gerd Hoffmann wrote:
> Hi,
>
>> +if [ "$capstone_internal" = "yes" ]; then
>> + echo "config-host.h: subdir-capstone" >> $config_host_mak
>> +fi
>
> I think this isn't going to work correctly. In case both capstone and
> dtc are used we need a single line with the depe
On 10/17/2017 10:48 PM, Gerd Hoffmann wrote:
> Hi,
>
>> +if [ "$capstone_internal" = "yes" ]; then
>> + echo "config-host.h: subdir-capstone" >> $config_host_mak
>> +fi
>
> I think this isn't going to work correctly. In case both capstone and
> dtc are used we need a single line with the depe
Hi,
> +if [ "$capstone_internal" = "yes" ]; then
> + echo "config-host.h: subdir-capstone" >> $config_host_mak
> +fi
I think this isn't going to work correctly. In case both capstone and
dtc are used we need a single line with the dependencies, i.e.
config-host.h: subdir-dtc subdir-capston
Do not require the submodule, but use it if present (in preference
even to a system copy). This will allow us to easily use capstone
in older systems for which a package is not available, and also
easily track bug fixes from upstream.
Cc: Gerd Hoffmann
Signed-off-by: Richard Henderson
---
Make
