Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2019-01-17 Thread John Snow
On 1/9/19 2:21 PM, Eric Blake wrote: > Why are we restricting things to only export disabled bitmaps? Late reply, but the original thought almost surely was that we would only be exporting bitmaps for fleecing use, which should have a non-changing bitmap attached to it. Just some error checkin

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2019-01-09 Thread Eric Blake
On 1/9/19 1:21 PM, Eric Blake wrote: > Revisiting an older thread: > > On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: >> Handle new NBD meta namespace: "qemu", and corresponding queries: >> "qemu:dirty-bitmap:". >> >> With new metadata context negotiated, BLOCK_STATUS query will reply >>

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2019-01-09 Thread Eric Blake
Revisiting an older thread: On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: > Handle new NBD meta namespace: "qemu", and corresponding queries: > "qemu:dirty-bitmap:". > > With new metadata context negotiated, BLOCK_STATUS query will reply > with dirty-bitmap data, converted to extents. N

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-11-28 Thread Eric Blake
On 6/9/18 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-09-14 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 21:09, Eric Blake wrote: On 06/20/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: 20.06.2018 19:27, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new meta

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-21 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 21:09, Eric Blake wrote: On 06/20/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: 20.06.2018 19:27, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new meta

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Eric Blake
On 06/20/2018 12:04 PM, Vladimir Sementsov-Ogievskiy wrote: 20.06.2018 19:27, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 19:27, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extent

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Eric Blake
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bit

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Eric Blake
On 06/20/2018 10:43 AM, Eric Blake wrote: On 06/20/2018 06:24 AM, Eric Blake wrote: +/* Set several extents, describing region of given @length with given @flags. + * Do not set more than @nb_extents, return number of set extents. + */ +static unsigned add_extents(NBDExtent *extents, unsigned

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Eric Blake
On 06/20/2018 06:24 AM, Eric Blake wrote: +/* Set several extents, describing region of given @length with given @flags. + * Do not set more than @nb_extents, return number of set extents. + */ +static unsigned add_extents(NBDExtent *extents, unsigned nb_extents, +    ui

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Vladimir Sementsov-Ogievskiy
20.06.2018 14:24, Eric Blake wrote: On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: s/new/a new/ "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply s/new/the new/ with di

Re: [Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-20 Thread Eric Blake
On 06/09/2018 10:17 AM, Vladimir Sementsov-Ogievskiy wrote: Handle new NBD meta namespace: "qemu", and corresponding queries: s/new/a new/ "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply s/new/the new/ with dirty-bitmap data, converted to extents

[Qemu-devel] [PATCH v5 4/6] nbd/server: implement dirty bitmap export

2018-06-09 Thread Vladimir Sementsov-Ogievskiy
Handle new NBD meta namespace: "qemu", and corresponding queries: "qemu:dirty-bitmap:". With new metadata context negotiated, BLOCK_STATUS query will reply with dirty-bitmap data, converted to extents. New public function nbd_export_bitmap selects bitmap to export. For now, only one bitmap may be