Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Amos Kong
On Thu, Jun 19, 2014 at 04:03:28AM +, Gonglei (Arei) wrote: > Hi, > > > -Original Message- > > From: Amos Kong [mailto:ak...@redhat.com] > > Sent: Thursday, June 19, 2014 11:58 AM > > To: Stefan Hajnoczi > > Cc: qemu-devel@nongnu.org; Gonglei (Arei); afaer...@suse.de; > > pbonz...@redh

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Gonglei (Arei)
Hi, > -Original Message- > From: Amos Kong [mailto:ak...@redhat.com] > Sent: Thursday, June 19, 2014 11:58 AM > To: Stefan Hajnoczi > Cc: qemu-devel@nongnu.org; Gonglei (Arei); afaer...@suse.de; > pbonz...@redhat.com; kw...@redhat.com > Subject: Re: [PATCH v5 4/4] virtio-blk-test.c: add ho

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Amos Kong
On Thu, Jun 19, 2014 at 11:49:08AM +0800, Stefan Hajnoczi wrote: > On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote: > > +for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) { > > +for (j = MAX_PCI_FUNC; j >= 0; j--) { > > +if (j == MAX_PCI_FUNC) { > > +q

Re: [Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Stefan Hajnoczi
On Thu, Jun 19, 2014 at 12:24:13AM +0800, Amos Kong wrote: > +for (i = MIN_PCI_SLOT; i <= MAX_PCI_SLOT; i++) { > +for (j = MAX_PCI_FUNC; j >= 0; j--) { > +if (j == MAX_PCI_FUNC) { > +qmp_exec_hmp_cmd("", "drive_del drv-%x.%x", i, 0); > +} Why is

[Qemu-devel] [PATCH v5 4/4] virtio-blk-test.c: add hotplug subtest

2014-06-18 Thread Amos Kong
This patch adds a new subtest, it hotplugs 29 * 8 = 232 virtio-blk devices to guest, and try to hot-unplug them. Note: the hot-unplug can't work without cooperation of guest OS. Signed-off-by: Amos Kong --- tests/virtio-blk-test.c | 68 + 1 file c