Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-04-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 13/04/2015 13:35, Dr. David Alan Gilbert wrote: > >>> +qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); > >>> > >>> > > +*old_vm_running = runstate_is_running(); > > > >> > > > > >> > I think that needs some expla

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 13:35, Dr. David Alan Gilbert wrote: >>> +qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); >>> > >>> > > +*old_vm_running = runstate_is_running(); > > >> > > > >> > I think that needs some explanation. Why are you doing a wakeup on > > >> > the sou

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-04-13 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 26/03/2015 12:05, Dr. David Alan Gilbert wrote: > >>> > > +qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); > >>> > > +*old_vm_running = runstate_is_running(); > >> > > >> > I think that needs some explanation. Why are you doing

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-03-30 Thread Paolo Bonzini
On 26/03/2015 12:05, Dr. David Alan Gilbert wrote: >>> > > +qemu_system_wakeup_request(QEMU_WAKEUP_REASON_OTHER); >>> > > +*old_vm_running = runstate_is_running(); >> > >> > I think that needs some explanation. Why are you doing a wakeup on >> > the source host? > This matches the exist

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-03-26 Thread Dr. David Alan Gilbert
* David Gibson (da...@gibson.dropbear.id.au) wrote: > On Wed, Feb 25, 2015 at 04:51:53PM +, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Rework the migration thread to setup and start postcopy. > > > > Signed-off-by: Dr. David Alan Gilbert > > --- > > incl

Re: [Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-03-22 Thread David Gibson
On Wed, Feb 25, 2015 at 04:51:53PM +, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Rework the migration thread to setup and start postcopy. > > Signed-off-by: Dr. David Alan Gilbert > --- > include/migration/migration.h | 3 + > migration/migration.c |

[Qemu-devel] [PATCH v5 30/45] Postcopy: Postcopy startup in migration thread

2015-02-25 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Rework the migration thread to setup and start postcopy. Signed-off-by: Dr. David Alan Gilbert --- include/migration/migration.h | 3 + migration/migration.c | 161 -- trace-events | 4 ++ 3 fil