Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-25 Thread Philippe Mathieu-Daudé
On Wed, Jun 21, 2017 at 1:37 PM, Richard Henderson wrote: > On 06/21/2017 09:18 AM, Philippe Mathieu-Daudé wrote: >> What an awful name... Anyway checking on "qemu/bswap.h" it seems there is >> some endianess issue with it if your host is little-endian. > > > There is no endian-ness issue because

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-21 Thread Laurent Vivier
Le 21/06/2017 à 18:37, Richard Henderson a écrit : > On 06/21/2017 09:18 AM, Philippe Mathieu-Daudé wrote: >>> +typedef CPU_LDoubleU FPReg; >> >> What an awful name... Anyway checking on "qemu/bswap.h" it seems there >> is some endianess issue with it if your host is little-endian. > > There is no

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-21 Thread Richard Henderson
On 06/21/2017 09:18 AM, Philippe Mathieu-Daudé wrote: +typedef CPU_LDoubleU FPReg; What an awful name... Anyway checking on "qemu/bswap.h" it seems there is some endianess issue with it if your host is little-endian. There is no endian-ness issue because we do not attempt to read that struct

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-21 Thread Philippe Mathieu-Daudé
Hi Laurent, On 06/20/2017 05:51 PM, Laurent Vivier wrote: Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 4 +- target/m68k/cpu.h| 15 +- t

Re: [Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-20 Thread Richard Henderson
On 06/20/2017 01:51 PM, Laurent Vivier wrote: Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- Reviewed-by: Richard Henderson r~

[Qemu-devel] [PATCH v5 3/6] target-m68k: use floatx80 internally

2017-06-20 Thread Laurent Vivier
Coldfire uses float64, but 680x0 use floatx80. This patch introduces the use of floatx80 internally and enables 680x0 80bits FPU. Signed-off-by: Laurent Vivier --- target/m68k/cpu.c| 4 +- target/m68k/cpu.h| 15 +- target/m68k/fpu_helper.c | 85 --- target/m68k/helper.c