Re: [Qemu-devel] [PATCH v5 3/6] BitmapLog: get the information about the parameters

2014-08-12 Thread Eric Blake
On 07/31/2014 09:12 PM, Sanidhya Kashyap wrote: > No functional change except the variable name. This comment feels more like it is a changelog of what is different from v4. If so, it belongs... > > Signed-off-by: Sanidhya Kashyap > --- ...here, after the --- separator. It makes no sense in

Re: [Qemu-devel] [PATCH v5 3/6] BitmapLog: get the information about the parameters

2014-08-12 Thread Dr. David Alan Gilbert
* Sanidhya Kashyap (sanidhya.ii...@gmail.com) wrote: > No functional change except the variable name. > > Signed-off-by: Sanidhya Kashyap > --- > hmp-commands.hx | 2 ++ > hmp.c| 19 +++ > hmp.h| 1 + > monitor.c| 7 +++ > qapi-schema.json

[Qemu-devel] [PATCH v5 3/6] BitmapLog: get the information about the parameters

2014-07-31 Thread Sanidhya Kashyap
No functional change except the variable name. Signed-off-by: Sanidhya Kashyap --- hmp-commands.hx | 2 ++ hmp.c| 19 +++ hmp.h| 1 + monitor.c| 7 +++ qapi-schema.json | 28 qmp-commands.hx | 25 ++