Re: [Qemu-devel] [PATCH v5 3/5] nvdimm acpi: let qemu handle _DSM method

2016-03-04 Thread Xiao Guangrong
On 03/03/2016 09:23 PM, Michael S. Tsirkin wrote: + * + * They are RAM mapping on host so that these accesses never cause + * VM-EXIT. + */ +field = aml_field("NRAM", AML_DWORD_ACC, AML_NOLOCK, AML_PRESERVE); +aml_append(field, aml_named_field("HDLE", + si

Re: [Qemu-devel] [PATCH v5 3/5] nvdimm acpi: let qemu handle _DSM method

2016-03-03 Thread Xiao Guangrong
On 03/03/2016 09:23 PM, Michael S. Tsirkin wrote: +struct NvdimmDsmIn { +uint32_t handle; +uint32_t revision; +uint32_t function; + /* the remaining size in the page is used by arg3. */ Pls fix indentation so /* aligns with union. Good eyes. Surprise me that checkpatch did

Re: [Qemu-devel] [PATCH v5 3/5] nvdimm acpi: let qemu handle _DSM method

2016-03-03 Thread Michael S. Tsirkin
On Wed, Mar 02, 2016 at 07:50:39PM +0800, Xiao Guangrong wrote: > If dsm memory is successfully patched, we let qemu fully emulate > the dsm method > > This patch saves _DSM input parameters into dsm memory, tell dsm > memory address to QEMU, then fetch the result from the dsm memory > > Signed-o

[Qemu-devel] [PATCH v5 3/5] nvdimm acpi: let qemu handle _DSM method

2016-03-02 Thread Xiao Guangrong
If dsm memory is successfully patched, we let qemu fully emulate the dsm method This patch saves _DSM input parameters into dsm memory, tell dsm memory address to QEMU, then fetch the result from the dsm memory Signed-off-by: Xiao Guangrong --- hw/acpi/nvdimm.c | 117 +++