Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-25 Thread David Gibson
On Mon, May 25, 2015 at 03:53:52PM +0530, Nikunj A Dadhania wrote: > Alexey Kardashevskiy writes: > > On 05/25/2015 02:45 PM, Nikunj A Dadhania wrote: > >> Alexey Kardashevskiy writes: [snip] > >>> Can we also add a hack here to scan for the "qemu,phb-enumerated" string > >>> in > >>> the SLOF b

Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-25 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 05/25/2015 02:45 PM, Nikunj A Dadhania wrote: >> Alexey Kardashevskiy writes: >> /* create OF node for pci device and required OF DT properties */ -static void *spapr_create_pci_child_dt(sPAPRPHBState *phb, PCIDevice *dev, -

Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-25 Thread Alexey Kardashevskiy
On 05/25/2015 02:45 PM, Nikunj A Dadhania wrote: Alexey Kardashevskiy writes: On 05/19/2015 06:26 PM, Nikunj A Dadhania wrote: All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple c

Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-24 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 05/19/2015 06:26 PM, Nikunj A Dadhania wrote: >> All the PCI enumeration and device node creation was off-loaded to >> SLOF. With PCI hotplug support, code needed to be added to add device >> node. This creates multiple copy of the code one in SLOF and other in >

Re: [Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-24 Thread Alexey Kardashevskiy
On 05/19/2015 06:26 PM, Nikunj A Dadhania wrote: All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch ad

[Qemu-devel] [PATCH v5 3/4] spapr_pci: enumerate and add PCI device tree

2015-05-19 Thread Nikunj A Dadhania
All the PCI enumeration and device node creation was off-loaded to SLOF. With PCI hotplug support, code needed to be added to add device node. This creates multiple copy of the code one in SLOF and other in hotplug code. To unify this, the patch adds the pci device node creation in Qemu. For backwa