Re: [Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode'

2017-07-27 Thread Stefan Hajnoczi
On Tue, Jul 25, 2017 at 07:10:10PM +0200, Amador Pahim wrote: > The 'returncode' Popen attribute is not guaranteed to be updated. It > actually depends on a call to either poll(), wait() or communicate(). > > On the other hand, poll() will "Check if child process has terminated. > Set and return r

[Qemu-devel] [PATCH v5 2/6] qemu.py: use poll() instead of 'returncode'

2017-07-25 Thread Amador Pahim
The 'returncode' Popen attribute is not guaranteed to be updated. It actually depends on a call to either poll(), wait() or communicate(). On the other hand, poll() will "Check if child process has terminated. Set and return returncode attribute." Let's use the poll() to check whether the process